Ok with that as well. However, considering Chris's comments all STM BSPs would 
need a second UART as it is not created in the BSPs.

Regards,
Vipul Rahane

> On Apr 18, 2017, at 9:41 AM, Christopher Collins <ch...@runtime.io> wrote:
> 
> I'm also OK with that.
> 
> FYI- apps which need to support both the shell and newtmgr over serial
> would need the following modifications:
>    1. Replace mgmt/newtmgr/transport/nmgr_shell dependency with
>       mgmt/newtmgr/transport/nmgr_uart
>    2. Enable a second UART in the project's syscfg (this would be a BSP
>       setting, likely UART_1).  For nRF BSPs, this would be the bit
>       banger UART.
>    3. Specify the appropriate UART as the value of the NMGR_UART syscfg
>       setting.  Currently, the console UART is hardcoded per-BSP and
>       not configurable via syscfg, but the newtmgr UART is configurable
>       (is there a reason this is hardcoded, or is it just a historical
>       thing?).
> 
> I think that is everything that would need to be done.
> 
> Chris
> 
> On Tue, Apr 18, 2017 at 09:31:59AM -0700, marko kiiskila wrote:
>> +1, I’d be ok dropping that support.
>> 
>>> On Apr 18, 2017, at 3:58 AM, Michał Narajowski 
>>> <michal.narajow...@codecoup.pl> wrote:
>>> 
>>> Hi,
>>> 
>>> I implemented some console improvements and submitted a pull request
>>> here: https://github.com/apache/incubator-mynewt-core/pull/230
>>> 
>>> Marko pointed out that it breaks newtmgr and OIC over shell. Should I
>>> fix those issues or can we drop support for that? How many people care
>>> about it?
>>> 
>>> Best regards,
>>> Michał
>> 

Reply via email to