sanha commented on a change in pull request #33: [NEMO-111] Remove
ExecutionProperty.Key
URL: https://github.com/apache/incubator-nemo/pull/33#discussion_r195632008
##########
File path:
common/src/main/java/edu/snu/nemo/common/ir/executionproperty/ExecutionPropertyMap.java
##########
@@ -103,46 +106,46 @@ public String getId() {
/**
* Put the given execution property in the ExecutionPropertyMap.
* @param executionProperty execution property to insert.
- * @return the inserted execution property.
+ * @return this map
*/
- public ExecutionProperty<?> put(final ExecutionProperty<?>
executionProperty) {
- return properties.put(executionProperty.getKey(), executionProperty);
+ public ExecutionPropertyMap put(final T executionProperty) {
Review comment:
Why do we return the map itself in here? It does not match with the
interface of Java map. Is there any specific reason?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
