sanha commented on a change in pull request #33: [NEMO-111] Remove
ExecutionProperty.Key
URL: https://github.com/apache/incubator-nemo/pull/33#discussion_r195634791
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/SerializerManager.java
##########
@@ -51,23 +50,22 @@ public SerializerManager() {
*
* @param runtimeEdgeId id of the runtime edge.
* @param coder the corresponding coder.
- * @param propertyMap ExecutionPropertyMap of runtime edge
+ * @param compressionProperty compression property
*/
public void register(final String runtimeEdgeId,
final Coder coder,
- final ExecutionPropertyMap propertyMap) {
+ final Optional<CompressionProperty.Value>
compressionProperty) {
Review comment:
It would be good to avoid to use `Optional` as an arguments.
(Please check
[here](https://stackoverflow.com/questions/31922866/why-should-java-8s-optional-not-be-used-in-arguments).)
How about separate the method w/ and w/o compression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
