seojangho commented on a change in pull request #48: [NEMO-72] Instance-based Encoder/Decoder interface URL: https://github.com/apache/incubator-nemo/pull/48#discussion_r196275597
########## File path: common/src/main/java/edu/snu/nemo/common/coder/IntDecoder.java ########## @@ -0,0 +1,69 @@ +/* + * Copyright (C) 2018 Seoul National University + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package edu.snu.nemo.common.coder; + +import java.io.*; + +/** + * A {@link Decoder} which is used for an integer. + */ +public final class IntDecoder implements Decoder<Integer> { + + /** + * A private constructor. + */ + private IntDecoder() { + // do nothing. + } + + /** + * Static initializer of the coder. + */ + public static IntDecoder of() { + return new IntDecoder(); + } + + @Override + public DecoderInstance<Integer> getDecoderInstance(final InputStream inputStream) { + return new IntDecoderInstance(inputStream); + } + + /** + * IntDecoderInstance. + */ + private final class IntDecoderInstance implements DecoderInstance<Integer> { + + private final InputStream inputStream; + + /** + * Constructor. + * + * @param inputStream the input stream to decode. + */ + private IntDecoderInstance(final InputStream inputStream) { + this.inputStream = inputStream; + } + + @Override + public Integer decode() throws IOException { + // If the inStream is closed well in upper level, it is okay to not close this stream + // because the DataInputStream itself will not contain any extra information. + // (when we close this stream, the inStream will be closed together.) Review comment: I suggest adding `finalize` or `cleanup` method to `EncoderInstance`/`DecoderInstance` interface to cleanup additional resources that CoderInstances may have created. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
