sanha commented on a change in pull request #115: [NEMO-96] Modularize
DataSkewPolicy to use MetricVertex and BarrierVertex
URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214388555
##########
File path:
runtime/common/src/main/java/edu/snu/nemo/runtime/common/plan/StagePartitioner.java
##########
@@ -109,6 +110,9 @@ private boolean testMergeability(final IREdge edge, final
DAG<IRVertex, IREdge>
!= CommunicationPatternProperty.Value.OneToOne) {
return false;
}
+ if (edge.getDst() instanceof AggregationBarrierVertex) {
+ return false;
Review comment:
Why should it be separated? Doesn't this vertex receives shuffle edge from
metric collection vertices? If so, it will be naturally separated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
