sanha commented on a change in pull request #115: [NEMO-96] Modularize
DataSkewPolicy to use MetricVertex and BarrierVertex
URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214387359
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/OutputCollectorImpl.java
##########
@@ -55,14 +66,20 @@ public void emit(final O output) {
emit((O) output);
} else {
// Note that String#hashCode() can be cached, thus accessing additional
output queues can be fast.
- final List<Object> dataElements =
this.additionalTagElementsMap.get(dstVertexId);
- if (dataElements == null) {
- throw new IllegalArgumentException("Wrong destination vertex id
passed!");
- }
+ final List<Object> dataElements =
getAdditionalTaggedDataFromDstVertexId(dstVertexId);
dataElements.add(output);
}
}
+ public void printLog() {
Review comment:
The method title seems too general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
