sanha commented on a change in pull request #115: [NEMO-96] Modularize
DataSkewPolicy to use MetricVertex and BarrierVertex
URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214886675
##########
File path:
common/src/main/java/edu/snu/nemo/common/ir/vertex/transform/MetricCollectTransform.java
##########
@@ -15,58 +15,51 @@
*/
package edu.snu.nemo.common.ir.vertex.transform;
-import edu.snu.nemo.common.KeyExtractor;
-import edu.snu.nemo.common.Pair;
import edu.snu.nemo.common.ir.OutputCollector;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.util.HashMap;
-import java.util.Map;
+import java.util.function.BiFunction;
/**
- * A {@link Transform} relays input data from upstream vertex to downstream
vertex promptly.
- * This transform can be used for merging input data into the {@link
OutputCollector}.
- * @param <T> input/output type.
+ * A {@link Transform} that collects task-level statistics used for dynamic
optimization.
+ * The collected statistics is sent to vertex with {@link
AggregateMetricTransform} as a tagged output
+ * when this transform is closed.
+ *
+ * @param <I> input type.
+ * @param <O> output type.
*/
-public final class MetricCollectTransform<T> implements Transform<T, T> {
+public final class MetricCollectTransform<I, O> implements Transform<I, O> {
private static final Logger LOG =
LoggerFactory.getLogger(MetricCollectTransform.class.getName());
- private OutputCollector<T> outputCollector;
- private final String dstvertexId;
- private final KeyExtractor keyExtractor;
- private Map<Object, Long> dynOptData;
+ private OutputCollector<O> outputCollector;
+ private O dynOptData;
+ private BiFunction<Object, O, O> dynOptDataCollector;
+ private BiFunction<O, OutputCollector, O> closer;
Review comment:
final?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
