sanha commented on a change in pull request #115: [NEMO-96] Modularize
DataSkewPolicy to use MetricVertex and BarrierVertex
URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214889060
##########
File path: common/src/main/java/edu/snu/nemo/common/coder/DecoderFactory.java
##########
@@ -84,6 +85,11 @@ public Decoder create(final InputStream inputStream) {
return dummyDecoder;
}
+ @Override
+ public Object getCoder() {
Review comment:
When is this method used? Do we really need this method for all factories?
Because it returns `Object`, users who use `DecoderFactory` can't expect any
general functionality from this code.
If it is needed just for key coder factory, it would be enough to implement
this in `BeamDecoderFactory` and `SparkDecoderFactory` specifically, because
they can be referenced in compiler frontend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
