johnyangk commented on a change in pull request #137: [NEMO-232] Implement
InputWatermarkManager
URL: https://github.com/apache/incubator-nemo/pull/137#discussion_r229598008
##########
File path:
runtime/executor/src/test/java/org/apache/nemo/runtime/executor/task/TaskExecutorTest.java
##########
@@ -330,6 +261,74 @@ public void testParentTaskDataFetching() throws Exception
{
assertTrue(checkEqualElements(elements,
runtimeEdgeToOutputData.get(taskOutEdge.getId())));
}
+ /**
+ * The DAG of the task to test will looks like:
+ * source1 -> vertex1 -> vertex2
+ * source2 -> vertex3 ->
+ *
+ * The vertex2 has two incoming edges (from vertex1 and vertex3)
+ * and we test if TaskExecutor handles data and watermarks correctly in this
situation.
+ *
+ * The source1 emits watermark 500, 1800 and source2 emits watermark 1000.
+ * The vertex2 should receive and emit watermarks 500 and 1000.
Review comment:
If watermarks come in this order
source1: 500
source1: 1800
source2: 1000
Shouldn't there be only a single emission of 1000?
Can you comment on the assumptions made in this test, and how the
assumptions are ensured?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
