johnyangk commented on a change in pull request #137: [NEMO-232] Implement InputWatermarkManager URL: https://github.com/apache/incubator-nemo/pull/137#discussion_r229596058
########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/task/TaskExecutor.java ########## @@ -478,17 +511,24 @@ private boolean handleDataFetchers(final List<DataFetcher> fetchers) { return map; } - private Map<String, List<OperatorVertex>> getInternalAdditionalOutputMap( + private Map<String, List<NextOperatorInfo>> getInternalAdditionalOutputMap( Review comment: Maybe merge `getInternalAdditionalOutputMap` and `getInternalMainOutputs`, and remove the intermediate`edgeIndexMap`? Pair<internal, additional> merged() { internal = new; additional = new; for (outedge) { if ... then internal.add(index, ...) else additional.add(index, ...) } } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services