taegeonum commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234860686
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -134,6 +131,7 @@ public void onData(final WindowedValue<KV<K, InputT>>
element) {
private void processElementsAndTriggerTimers(final Watermark inputWatermark,
final Instant processingTime,
final Instant synchronizedTime)
{
+ checkAndInvokeBundle();
Review comment:
It is invoked whenever receiving watermarks, but `DoFnTransform` does not
call `checkAndInvokeBundle` and `checkAndFinishBundle` in `onWatermark`.
I prefer consistency so could you please move this and 155 line to 193 and
197, and also add `checkAndInvokeBundle` and `checkAndFinishBundle` in
`onWatermark` of `DoFnTransform`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
