taegeonum commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234859767
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CreateViewTransform.java
##########
@@ -37,21 +37,19 @@
* @param <I> input type
* @param <O> materialized output type
*/
-public final class CreateViewTransform<I, O> implements
- Transform<WindowedValue<KV<?, I>>, WindowedValue<O>> {
- private OutputCollector<WindowedValue<O>> outputCollector;
- private final ViewFn<Materializations.MultimapView<Void, ?>, O> viewFn;
+public final class CreateViewTransform<I, O> implements
Transform<WindowedValue<KV<?, I>>, WindowedValue<O>> {
+ private final ViewFn<Object, O> viewFn;
private final Map<BoundedWindow, List<I>> windowListMap;
- // TODO #259: we can remove this variable by implementing
ReadyCheckingSideInputReader
- private boolean isEmitted = false;
+ private OutputCollector<WindowedValue<O>> outputCollector;
+
private long currentOutputWatermark;
/**
* Constructor of CreateViewTransform.
- * @param viewFn the viewFn that materializes data.
+ * @param viewFn the view function.
Review comment:
why is this comment changed? I think `viewFn` materializes the data
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
