johnyangk commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234910095
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CreateViewTransform.java
##########
@@ -112,20 +113,12 @@ public void onWatermark(final Watermark inputWatermark) {
@Override
public void close() {
onWatermark(new Watermark(BoundedWindow.TIMESTAMP_MAX_VALUE.getMillis()));
-
- if (!isEmitted) {
Review comment:
I think so (PerPercentile test passes)
It will be handled more explicitly in
https://github.com/apache/incubator-nemo/pull/159/files#diff-30a095310e20d5a90938099d206b1757R32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
