johnyangk commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234914914
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/task/MultiThreadParentTaskDataFetcher.java
##########
@@ -99,35 +96,14 @@ Object fetchDataElement() throws IOException,
NoSuchElementException {
private void fetchDataLazily() {
final List<CompletableFuture<DataUtil.IteratorWithNumBytes>> futures =
readersForParentTask.read();
numOfIterators = futures.size();
-
- if (numOfIterators > 1) {
Review comment:
I've reverted the code 😄
Considering that it makes the InputWatermarkManager come "in front" of the
data fetcher, and hides indices from TaskExecutor.
Although there are disadvantages of a bit more complex code, and having to
handle indices in each DataFetcher.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
