Hello, all. I've filed a PR to exclude the example jars from deployment over the weekend. (As mentioned earlier, I have firewall issues during the day time)
Once this is merged, I'll send out a vote for the 2nd candidate. Thanks! Best, Joo Yeon On Thu, Dec 6, 2018 at 2:10 PM 송원욱 <won...@apache.org> wrote: > +1 for source-only as well > Wonook > > > 2018년 12월 6일 (목) 오후 1:54, Jangho Seo <jan...@apache.org>님이 작성: > > > +1 for releasing source-only. > > > > Best, > > Jangho > > > > On 12/5/18 6:17 PM, Byung-Gon Chun wrote: > > > +1 for releasing only source code > > > > > > On Wed, Dec 5, 2018 at 6:01 PM Taegeon Um <taegeo...@gmail.com> wrote: > > > > > >> Thanks Joo Yeon! > > >> > > >>> On 3 Dec 2018, at 6:16 PM, Joo Yeon Kim <jooy...@apache.org> wrote: > > >>> > > >>> Thank you mentors for the feedback and the vote! > > >>> > > >>> I've received a few requests to include the features merged to master > > >> after > > >>> rc1, if possible. > > >>> It looks like I'll be setting up another tarball as per Gon's request > > >>> anyway, so let's go ahead with another release candidate. > > >>> Apologies to Davor, Jean-Baptiste and Gon for the inconvenience, it > > looks > > >>> like we need to vote again :( > > >>> > > >>> Regarding the comments we received: > > >>> 1. I've filed a PR to check license headers, and it will be included > in > > >> rc2. > > >>> 2. @developers, > > >>> What are your opinions about Davor's comment? > > >>> > > >>> > > >> +1 for release source-only. > > >> > > >>> > > >>> > > >>> *-> Examples produce shaded artifact, which bundles parts of Beam, > > >>> Spark.This bundling requires updates to license and notice files. > But, > > >>> thisshading process doesn't change what the main output JAR is, or > what > > >>> isbeing uploaded to Nexus. I'm not sure what's the value of releasing > > >>> binaryexamples when nobody should link against them. I'd guess you'd > > want > > >>> tochange this either to a Maven archetype or release source-only. * > > >>> > > >>> Best, > > >>> Joo Yeon > > >>> > > >>> On Mon, Dec 3, 2018 at 7:06 AM Byung-Gon Chun <bgc...@gmail.com> > > wrote: > > >>> > > >>>> +1 (binding) > > >>>> > > >>>> Great work! PGP and checksums look good. > > >>>> clean-install on Mac OS X/Java 1.8 works fine. > > >>>> > > >>>> Joo Yeon, one minor improvement to add. > > >>>> The files in the tarball contain ^M (extra CR) characters. > > >>>> I'm guessing you probably generated the tar ball on Windows. > > >>>> > > >>>> Best, > > >>>> Gon > > >>>> > > >>>> > > >>>> On Mon, Dec 3, 2018 at 4:19 AM Jean-Baptiste Onofré < > j...@nanthrax.net> > > >>>> wrote: > > >>>> > > >>>>> +1 (binding) > > >>>>> > > >>>>> Good work, I just did a quick review. As mentioned by Davor, there > > are > > >>>>> some minor improvements to do for the next release. > > >>>>> > > >>>>> Regards > > >>>>> JB > > >>>>> > > >>>>> On 02/12/2018 19:40, Davor Bonaci wrote: > > >>>>>> +1 (binding) > > >>>>>> > > >>>>>> Great job! > > >>>>>> > > >>>>>> Things to improve, none of which I consider release-blocking: > > >>>>>> > > >>>>>> - Missing Apache header in a few files, mostly XML and like files. > > It > > >>>>> would > > >>>>>> be great to make all that part of checkstyle. > > >>>>>> > > >>>>>> - Examples produce shaded artifact, which bundles parts of Beam, > > >> Spark. > > >>>>>> This bundling requires updates to license and notice files. But, > > this > > >>>>>> shading process doesn't change what the main output JAR is, or > what > > is > > >>>>>> being uploaded to Nexus. I'm not sure what's the value of > releasing > > >>>>> binary > > >>>>>> examples when nobody should link against them. I'd guess you'd > want > > to > > >>>>>> change this either to a Maven archetype or release source-only. > > >>>>>> > > >>>>>> You can choose to address (or push back against) these for this > > >> release > > >>>>> or > > >>>>>> the next subsequent release. The first requires a new vote, so I > > >>>> wouldn't > > >>>>>> recommend fixing it now, unless there are other issues. Depending > on > > >>>> how > > >>>>>> you want to address the second one, you may be able to fix it > within > > >>>>> Nexus, > > >>>>>> without a new candidate/vote. > > >>>>>> > > >>>>>>> If this is incorrect/less-preferable, please let me know so that > I > > >> can > > >>>>>>>> upload a new tarball. > > >>>>>> No, leave this as is. It is perfect. > > >>>>>> > > >>>>>> * * * > > >>>>>> > > >>>>>> Overall, I'm thrilled to see this release going out. Thank you for > > the > > >>>>>> great work. > > >>>>>> > > >>>> > > >>>> -- > > >>>> Byung-Gon Chun > > >>>> > > >> > > >
