Hi Markus,

Can you bump up your vote, then? Thanks!

-Gon

On Thu, Feb 6, 2020 at 1:48 AM Markus Weimer <wei...@apache.org> wrote:

> Thanks, this worked. I did it on a fresh installation of Ubuntu 18.04 (on
> WSL), and followed README.md.
>
> Markus
>
> On Wed, Feb 5, 2020 at 5:18 AM John Youngseok Yang <johnya...@gmail.com>
> wrote:
>
> > I've also confirmed that the above commands also work after nuking the
> > local maven repository.
> > (although then the installation time is much longer due to having to
> > download all of the dependencies from the internet)
> >
> > $ rm -rf ~/.m2
> > $ ... (same as above)
> >
> > John
> >
> >
> > On Wed, Feb 5, 2020 at 9:48 PM John Youngseok Yang <johnya...@gmail.com>
> > wrote:
> >
> > > Wonwook's PR is merged to the master and I think Nemo now runs on Java
> 8+
> > > (including 11).
> > >
> > > Markus, can you perhaps try again with the following commands starting
> > > from a clean slate?
> > > These commands seem to work on my laptop with the latest Nemo master.
> > > - Ubuntu 18.04.3 LTS
> > > - java version "1.8.0_171"
> > >
> > > Thank you by the way for looking into this problem.
> > >
> > > $ mkdir clean_slate_nemo
> > > $ cd clean_slate_nemo/
> > > $ git clone g...@github.com:apache/incubator-nemo.git
> > > $ cd incubator-nemo/
> > > $ mvn clean install -T 2C
> > >
> > > Thanks,
> > > John
> > >
> > >
> > > On Wed, Feb 5, 2020 at 7:48 PM Byung-Gon Chun <bgc...@gmail.com>
> wrote:
> > >
> > >> Any update?
> > >>
> > >> -Gon
> > >>
> > >> On Fri, Jan 31, 2020 at 7:16 PM 송원욱 <wsong0...@gmail.com> wrote:
> > >>
> > >> > I’ve investigated into the issue, and have succeeded to solve some
> > >> > problems by upgrading the versions of multiple java libraries. I’ve
> > >> > nevertheless faced a number of issues while upgrading the Beam
> > version,
> > >> and
> > >> > I’m trying to provide a fix ASAP 😀.
> > >> > I’ll file a PR as soon as I’m done :)
> > >> > hold tight!
> > >> >
> > >> > P.S. I’ll also look into the ITCase issue that arises while
> compiling
> > >> Nemo
> > >> > using multiple threads.
> > >> >
> > >> > - Wonook
> > >> >
> > >> > > On 31 Jan 2020, at 9:08 AM, Byung-Gon Chun <bgc...@gmail.com>
> > wrote:
> > >> > >
> > >> > > Wonook,
> > >> > >
> > >> > > Any update on the jdk 1.11 issue?
> > >> > >
> > >> > > Thanks.
> > >> > > -Gon
> > >> > >
> > >> > > On Thu, Jan 23, 2020 at 7:59 AM Byung-Gon Chun <bgc...@gmail.com>
> > >> wrote:
> > >> > >
> > >> > >> Hi Nemoers,
> > >> > >>
> > >> > >> It would be good to take a look at the problems Markus reported
> for
> > >> the
> > >> > >> release.
> > >> > >>
> > >> > >> -Gon
> > >> > >>
> > >> > >>
> > >> > >> On Thu, Jan 23, 2020 at 6:16 AM Markus Weimer <wei...@apache.org
> >
> > >> > wrote:
> > >> > >>
> > >> > >>> Thanks for the insight. I have switched to Java 8, and now a
> `mvn
> > >> > >>> compile` works. However, there seems to be some oddity going on
> > >> still.
> > >> > >>> `mvn install -DskipITs -DskipTests` still produces an error:
> > >> > >>>
> > >> > >>> ```
> > >> > >>> [ERROR]
> > >> > >>>
> > >> >
> > >>
> >
> /home/mweimer/nemo/incubator-nemo/runtime/executor/src/test/java/org/apache/nemo/runtime/executor/datatransfer/DataTransferT
> > >> > >>> est.java:[55,45] package org.apache.nemo.runtime.master.metric
> > does
> > >> not
> > >> > >>> exist
> > >> > >>> ```
> > >> > >>>
> > >> > >>> I also noticed that parallel builds don't succeed (`mvn -TC1
> > ...`).
> > >> > >>> Maybe there is a dependency not captured in the build files?
> Maven
> > >> has
> > >> > >>> a tendency to satisfy these dependencies out of the local maven
> > >> > >>> repository. However, I have no prior version of Nemo on my
> > >> machine...
> > >> > >>>
> > >> > >>> Meanwhile, I vote +0 on the release not to hold it up :)
> > >> > >>>
> > >> > >>> Markus
> > >> > >>>
> > >> > >>> On Wed, Jan 22, 2020 at 9:07 AM 송원욱 <wsong0...@gmail.com>
> wrote:
> > >> > >>>>
> > >> > >>>> It seems like the problem comes with the protobuf library,
> which
> > we
> > >> > >>> keep the version to 2.5.0 due to the dependency with REEF. It
> > seems
> > >> > like
> > >> > >>> the effort is non-negligible, but I’ll raise an issue on JIRA:
> > >> > >>> https://issues.apache.org/jira/browse/NEMO-437 <
> > >> > >>> https://issues.apache.org/jira/browse/NEMO-437>.
> > >> > >>>>
> > >> > >>>> +1 in the meanwhile :)
> > >> > >>>>
> > >> > >>>>> On Jan 22, 2020, at 9:57 PM, 송원욱 <wsong0...@gmail.com> wrote:
> > >> > >>>>>
> > >> > >>>>> It succeeds with Java 8 on my Mac as well, but fails with JDK
> > 11.
> > >> > >>> I’ll see what’s required to support JDK 11 and we could measure
> if
> > >> it
> > >> > would
> > >> > >>> be doable before the release.
> > >> > >>>>>
> > >> > >>>>>> On Jan 22, 2020, at 10:41 AM, Markus Weimer <
> wei...@apache.org
> > >
> > >> > >>> wrote:
> > >> > >>>>>>
> > >> > >>>>>> Hi,
> > >> > >>>>>>
> > >> > >>>>>> I have tried to compile Nemo, and hit an error:
> > >> > >>>>>>
> > >> > >>>>>> ```
> > >> > >>>>>> [ERROR] Failed to execute goal
> > >> > >>>>>> org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
> > >> > >>>>>> (default-compile) on project nemo-runtime-common: Compilation
> > >> > failure
> > >> > >>>>>> [ERROR]
> > >> > >>>
> > >> >
> > >>
> >
> /home/mweimer/incubator-nemo/runtime/common/target/generated-sources/protobuf/grpc-java/org/apache/nemo/runtime/common/comm/MessageServiceGrpc.java:[23,18]
> > >> > >>>>>> cannot find
> > >> > >>>>>> symbol
> > >> > >>>>>> [ERROR] symbol: class Generated
> > >> > >>>>>> [ERROR] location: package javax.annotation
> > >> > >>>>>> ```
> > >> > >>>>>>
> > >> > >>>>>> I am doing this on Ubuntu 18.04 on the Windows Subsystem for
> > >> Linux.
> > >> > I
> > >> > >>>>>> installed `mvn` via `sudo apt install maven` which pulled in
> > >> > >>>>>> `openjdk-11-jre-headless:amd64 (11.0.5+10-0ubuntu1.1~18.04)`
> as
> > >> the
> > >> > >>>>>> JDK.
> > >> > >>>>>>
> > >> > >>>>>> Has anyone else tried compiling on JDK 11?
> > >> > >>>>>>
> > >> > >>>>>> Thanks,
> > >> > >>>>>>
> > >> > >>>>>> Markus
> > >> > >>>>>>
> > >> > >>>>>> On Tue, Jan 21, 2020 at 3:58 PM Byung-Gon Chun <
> > bgc...@gmail.com
> > >> >
> > >> > >>> wrote:
> > >> > >>>>>>>
> > >> > >>>>>>> Thanks, Sanha!
> > >> > >>>>>>>
> > >> > >>>>>>> +1
> > >> > >>>>>>>
> > >> > >>>>>>> I checked the sha512 hash.
> > >> > >>>>>>> I verified the signature.
> > >> > >>>>>>> "mvn clean install" ran successfully.
> > >> > >>>>>>>
> > >> > >>>>>>> Great job!
> > >> > >>>>>>> -Gon
> > >> > >>>>>>>
> > >> > >>>>>>>
> > >> > >>>>>>> On Tue, Jan 21, 2020 at 11:53 PM Sanha Lee <
> sa...@apache.org>
> > >> > >>> wrote:
> > >> > >>>>>>>
> > >> > >>>>>>>> Hello Nemo PPMC.
> > >> > >>>>>>>>
> > >> > >>>>>>>> Because it's been a while since we discussed the release
> 0.2,
> > >> I'd
> > >> > >>> like to
> > >> > >>>>>>>> start voting.
> > >> > >>>>>>>>
> > >> > >>>>>>>> Please refer to the information below to vote on this
> > release,
> > >> and
> > >> > >>> vote:
> > >> > >>>>>>>>
> > >> > >>>>>>>> [ ] +1 Release this package as Apache Nemo (incubating)
> 0.2.0
> > >> > >>>>>>>> [ ] 0 I don't feel strongly about it, but the release seems
> > >> okay.
> > >> > >>>>>>>> [ ] -1 Please do not release this package because...
> > >> > >>>>>>>>
> > >> > >>>>>>>> 1. Source release files:
> > >> > >>>>>>>>
> > >> > >>>
> > >> https://dist.apache.org/repos/dist/dev/incubator/nemo/0.2-incubating/
> > >> > >>>>>>>>
> > >> > >>>>>>>> 2. The release tag:
> > >> > >>>>>>>>
> > >> > >>>>>>>>
> > >> > >>>
> > >> >
> > >>
> >
> https://github.com/apache/incubator-nemo/releases/tag/apache-nemo-0.2-incubating-rc1
> > >> > >>>>>>>>
> > >> > >>>>>>>>
> > >> > >>>>>>>> 3. The release hash:
> > >> > >>>>>>>>
> > >> > >>>>>>>>
> > >> > >>>
> > >> >
> > >>
> >
> https://github.com/apache/incubator-nemo/commit/6ca51e92408aa4cdcc0c68697b6590baa839ab9b
> > >> > >>>>>>>>
> > >> > >>>>>>>>
> > >> > >>>>>>>> 5. The KEYS file:
> > >> > >>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/nemo/KEYS
> > >> > >>>>>>>>
> > >> > >>>>>>>> Sincerely,
> > >> > >>>>>>>> Sanha
> > >> > >>>>>>>>
> > >> > >>>>>>>
> > >> > >>>>>>>
> > >> > >>>>>>> --
> > >> > >>>>>>> Byung-Gon Chun
> > >> > >>>>>
> > >> > >>>>
> > >> > >>>
> > >> > >>
> > >> > >>
> > >> > >> --
> > >> > >> Byung-Gon Chun
> > >> > >>
> > >> > >
> > >> > >
> > >> > > --
> > >> > > Byung-Gon Chun
> > >> >
> > >> >
> > >>
> > >> --
> > >> Byung-Gon Chun
> > >>
> > >
> >
>


-- 
Byung-Gon Chun

Reply via email to