On Thu, 11 Jul 2019, 20:05 Josh Juneau, <[email protected]> wrote: > > I have not yet created the PR, but I will do so. One question though, when > I compare files on the PR within my project on GitHub, it shows all of the > commit history for the Java EE 8 commits...so there are 13 commits showing > up in the PR. This is similar to the last PR I submitted that showed 12 > commits...I believe you probably remember this. Should I just go ahead and > proceed to submit the PR, or is there something I need to do with my fork > before submitting? >
It's because your commits were squashed and merged in the original PR so don't exist in the upstream history. Ideally keep your fork's master branch in sync with upstream and create a separate branch off it for each PR. I should be able to squash and merge the new PR to get it to work though, as I did with your last fixes, if you can't do above in time. Thanks and best wishes, Neil >
