Great, can you provide a PR to fix this, together with the PRs from Gaurav, Josh, and Toni, we’ll enable Neil to create beta-4 in preparation for vc2 early next week, yes, small slip, but we’re learning and it’s a process.
Gj On Thu, 11 Jul 2019 at 23:00, Laszlo Kishalmi <[email protected]> wrote: > -1 (binding) > > Dear all, > > You won't like me, as it is all my fault. > > What was checked: > > Checksum - OK > Signatures - OK > LICENSE, NOTICE, DEPENDENCIES - OK > NOTICE Year - FAIL > Build from Source - OK > Run on Ubuntu with OpenJDK8 - OK > Run on Ubuntu with OpenJDK11 - OK > Run on Ubuntu with OpenJDK12 - OK > Run Snap on Ubuntu - OK > No binaries, except for empty.jar and in tests - OK > License Headers on Files - FAIL > > The last one is actually caused by me. A few of my Gradle Web Plugin > files are having dual license headers, one with GPL2+CDDL followed by an > Apache2 header. Our RAT detects those files as Apache License. > > Having that in I cannot say +1 however I wish. I do not think that is a > real blocker, so you can still overrule me with +1-s, as it seems to be > a good release in every other aspect I've checked. > > On 7/10/19 12:41 PM, Neil C Smith wrote: > > Dear all, > > > > This is our first voting candidate for the 11.1 release of Apache > NetBeans. > > > > Apache NetBeans 11.1 constitutes all clusters in the Apache NetBeans > > Git repo, which together provide the NetBeans Platform (i.e., the > > underlying application framework), as well as all the modules that > > provide the Java SE, Java EE, PHP, JavaScript and Groovy features of > > Apache NetBeans. > > > > Build artefacts are available here: > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/11.1-vc1/ > > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-platform/11.1-vc1/ > > > > Included in the above are the DEPENDENCIES, DISCLAIMER, LICENSE, and > > NOTICE files, as well as a README file with build instructions, which > > are the same as these: > > https://github.com/apache/netbeans/blob/release111/README.md > > > > We are voting on: > > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/11.1-vc1/netbeans-11.1-vc1-source.zip > > > > SHA512: > > > 7f49cfca8d27f2e08d0e5d9b4f61d70baddfdfa013f4a783feb2a1e203d7a1c7208321cdb0be7aa49d469c027e221999c8c0e4b9d911eec35a7d2e3cf8859466 > > ./netbeans-11.1-vc1-source.zip > > > > KEYS file: > > https://dist.apache.org/repos/dist/release/netbeans/KEYS > > > > Apache NetBeans Git Repo tag: 11.1-vc1 : > > https://github.com/apache/netbeans/tree/11.1-vc1 > > > > Note: NetBeans license violation checks are managed via the > > rat-exclusions.txt file: > > > https://github.com/apache/netbeans/blob/release111/nbbuild/rat-exclusions.txt > > > > Rat report shows no unknown licenses, except for license files: > > > https://builds.apache.org/view/M-R/view/NetBeans/job/netbeans-release/423/artifact/rat-release-temp/nbbuild/build/rat-report.txt > > > > Release specific wiki page: > > > https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+11.1 > > > > > > How (and what) to try out with the release: > > > > 1. Download the artefact to be voted on and unzip it. > > 2. Check that the artefact does not contain any jar files, except for: > > - > platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/empty.jar > > - enterprise/glassfish.common/test/unit/data/nottaDir-4_1_2.jar > > - enterprise/glassfish.common/test/unit/data/subdir/nottaDir-5.0.jar > > - enterprise/payara.common/test/unit/data/nottaDir-4_1_2.jar > > - enterprise/payara.common/test/unit/data/subdir/nottaDir-5.0.jar > > which are only jars by their name > > 3. Verify the cryptographic signatures, the NOTICE and LICENSE file > > 4. Build it using the README provided by the artefact. > > 5. Look in nbbuild/netbeans for the NetBeans installation created by > > the build process. > > > > This vote is going to be open at least 72 hours, vote with +1, 0, and > > -1 as usual. Please mark your vote with (binding) if you're a > > NetBeans PMC member to help with voting admin. NetBeans 11.1 will be > > released if and when this vote passes. > > > > Convenience binaries, not relevant for voting purposes, are staged at > > the build artefacts links above. > > > > > > Thank you for all the hard work! > > And fingers X'd my first release voting thread is all correct - speak > > up if there are any issues. > > > > Best wishes, > > > > Neil > > Volunteer Release Manager for Apache NetBeans 11.1 > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > For further information about the NetBeans mailing lists, visit: > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
