(First, I applaud this effort!) Regarding what's in it for NetBeans, I think that's simple - hopefully more users!
VS Code already has a Java extension, based on Eclipse. So I don't think VS Code needs an extension based on NetBeans. But if some users will use a NetBeans-based extension, that's good, right? I really doubt anyone will switch from NetBeans to VS Code just because we will do a NetBeans-based extension to VS Code, so this does not seem to take any users from us. So I think we can just have some more/new users, who (for any reason) opted for a different GUI. Jan On Tue, Oct 6, 2020 at 4:48 PM Laszlo Kishalmi <[email protected]> wrote: > Well, > > First of all, contributions are welcome! Though, I have mixed feelings > about this one. Maybe I just do not see it at the moment. > > My question would be: What is in this contribution for NetBeans? > > I'm Ok with giving the java.lsp.server module inside NetBeans, as long > as it is not a dead code and seems to be maintained. In this case, > that'd be true. > > My problem is the packaging and distribution. Again what is the benefit > for NetBeans doing so? > > It is probably fine if Oracle contributes some code that packs the > necessary code together and a package would be dropped out at the end of > the build pipeline. It is also Ok if Oracle takes that package, bundle > it with something else and put that thing into the VSCode marketplace. > > S as I see it now. It would be an additional work for NetBeans profiting > Oracle and VSCode. That does not taste good. > > Prove me wrong, I change my mind. But for now, code is Ok, automated > packaging if provided, is Ok. Doing the distribution and Marketplace > thing, shall be off NetBeans. > > On 10/6/20 5:11 AM, Jaroslav Tulach wrote: > > Hi there. > > > > NetBeans source code contains language server for the Java language in > the > > `java/java.lsp.server` module for a while. The module has been integral > part > > of NetBeans for several releases. In addition to that there is a VSCode > > extension using that module - also part of the source ZIP releases, but > never > > part of any complementary binaries release. > > > > During the last few months the OracleLabs team worked hard on polishing > and > > improving the `java/java.lsp.server` module and associated extension. Our > > interest was (not only polyglot) debugging. We believe we got it almost > > working and we'd like to make our work part of the forthcoming 12.2 > release. > > > > We've been primarily [working on a branch]( > https://github.com/JaroslavTulach/ > > netbeans/tree/java-lsp-server-debugging-attempt2) with occasional > backports of > > our work to the `master` branch (like #2309, #2393, #2386) of the main > > NetBeans repository. We plan to continue doing that: > > > > * Sváťa Dědic works on splitting of HTML/CSS related modules to minimize > > "weight" of the Java-focused extension > > * Martin Entlicher will prepare necessary enhancements to the debugging > > modules and APIs > > * then we plan to integrate the `java.lsp.server` changes using the > previous > > enhancements > > * and eliminate the branch > > > > We'd like to integrate everything before 12.2 feature freeze (Oct 15) > and then > > work on bugfixes to polish the VSCode support for the 12.2 source > release. > > > > I assume there shall be no problem with that, if we keep Apache NetBeans > gate > > checks working and passing. Btw. if you are interested in working with > us, > > please start with the following README: > https://github.com/JaroslavTulach/ > > > netbeans/blob/java-lsp-server-debugging-attempt2/java/java.lsp.server/vscode/ > > README.md > > > > Please let me also describe that the ultimate goal of OracleLabs is to > promote > > GraalVM and provide the best tooling with the help of here-in discussed > > extension. OracleLabs will distribute additional code to smooth the > > integration with GraalVM - e.g. OracleLabs will upload own extension(s) > to > > Visual Studio Code Marketplace. There are two options: > > > > 1. take the NetBeans 12.2 source release bits & pieces and include them > in > > OracleLabs extension(s) > > 2. help the Apache NetBeans project produce another convenience binary, > upload > > it to the Marketplace and make OracleLabs extension(s) depend on it. > > > > The option #2 is certainly more proper from an architecture perspective. > > However can we make it? Work on 12.2 release is almost over and adding > such an > > undertaking such a late in the cycle may increase the risk of delaying > the > > release. How do you feel about it, Lazslo, as the 12.2 release > coordinator? > > > > Thanks for your opinions and thanks in advance for your support. With > NBCode > > people will be able to get the goodies of NetBeans (Maven projects, > Gradle > > support, Java code completion, Java debugging, polyglot debugging) via > the > > VSCode user interface! > > > > Best regards and let me admit I am so thrilled I can work on such > project! > > > > Jaroslav Tulach > > NetBeans Founder and Initial Architect > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > For further information about the NetBeans mailing lists, visit: > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
