Okay...I was able to get it to compile and run successfully. Haven't done
too much testing yet but seems in good shape so far.
Assume this may be in support of NETBEANS-4538
So wanted to see what may be needed to go forward with this.
It is still unclear to be about
(1) How to handle the missing files mentioned earlier (see earlier email
for more specifics)
(2) Is there expected to be any further "donation" activities which may
make some of this be overcome by other updates coming down the line?
(3) Is Oracle/Apache legal still working anything prior to acceptance?
(4) Since much of this is derived from the nbpython project, is there any
concerns from the nbpython project team?
a) I've had difficult contacting anyone due to stale or inaccessible
web sites or comms means
b) I'm hoping some folks on the list may be able to help here
(5) What needs to be done to include this incoming
build/release/milestone/components/etc.?
Assume one of the first steps would be check in and raise a PR but due to
my inexperience in this sort of major git activities, I may need some help
on this as I don't believe what I've done so far is quite right.
When pushing my local "python" branch changes to my fork (see
https://github.com/ebresie/netbeans) on a remote "python" branch there was
a mixture of activities going on at the same time when trying to check some
of this stuff in. Specifically there were changes including (1) periodic
upstream merge of recent change, (2) a separate cnd activities[which should
have been a separate branch but unfortunately got included with previous
updates] , and (3) mixture of maven vs non-maven python versions.
So all that is to say, this makes creating a PR rather difficult.. How can
I reconcile these issues in support of PR creation? Is there a way to
exclude these sorts of things in github PR (i.e. can I somehow delete the
other commits)? Do I need some squashed or some other git activities? Do
I need to somehow revert back to state prior to python getting merged and
without the "cnd" inclusion and then somehow merge the python changes in
some way on a fresh attempt? Git help is appreciated.
Eric Bresie
[email protected]
On Mon, Dec 28, 2020 at 8:30 PM Eric Bresie <[email protected]> wrote:
> Also in the python.editor module, in the scripts is a missing
> "coverage.py" file as well.
>
> I believe this is related to
> http://nedbatchelder.com/code/modules/coverage.html
> Or more recently https://coverage.readthedocs.io/en/latest/
>
> Assume this one may be left out on purpose. Assume can either (1) remove
> references to it elsewhere (where it's getting copied), (2) find a way to
> "import" as an external element of some type or (3) replace it in some
> other way.
>
> Eric Bresie
> [email protected]
>
>
> On Mon, Dec 28, 2020 at 6:56 PM Eric Bresie <[email protected]> wrote:
>
>> Okay...after a few failed attempts and a few more tweaks (I had to change
>> the location in the build.xml for each of the projects to point to the
>> python cluster subdirectory)...I was finally able to get it to build up to
>> a point...
>>
>> However ended with errors like the below.
>>
>> Seems
>> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java
>> depends on org.netbeans.modules.python.debugger.utils.MiscStatic which
>> appears to not be present. Did this get left out in the donation? I don't
>> see it in the hg.netbeans.org main/contrib version of this but do find
>> it in the maven version.
>>
>> Also seems to be missing package
>> org.netbeans.modules.python.source.scopes (also found in the maven version)
>> with which includes but not limited to classes like SymbolTable and
>> SymInfo. Are these the sort of files that may get removed as part of
>> donation and/or IP sanitizing of the donation?
>>
>> -do-compile:
>> [nb-javac] Compiling 75 source files to
>> C:\netbeans\python\python.debugger\build\classes
>> [repeat] warning: [options] bootstrap class path not set in
>> conjunction with -source 7
>> [repeat]
>> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory
>> in org.xml.sax.helpers has been deprecated
>> [repeat] import org.xml.sax.helpers.XMLReaderFactory;
>> [repeat] ^
>> [repeat]
>> C:\git\netbeans.ebresie\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java
>> [repeat] import org.netbeans.modules.python.debugger.utils.MiscStatic;
>> [repeat] ^
>> [repeat] symbol: class MiscStatic
>> [repeat] location: package org.netbeans.modules.python.debugger.utils
>> [repeat]
>> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory
>> in org.xml.sax.helpers has been deprecated
>> [repeat] import org.xml.sax.helpers.XMLReaderFactory;
>> [repeat] ^
>> [repeat] 1 error
>> [repeat] 3 warnings
>> [nbmerge] Failed to build target: all-python.debugger
>>
>> BUILD FAILED
>> C:\netbeans\nbbuild\build.xml:643: The following error occurred while
>> executing this line:
>> C:\netbeans\nbbuild\build.xml:638: The following error occurred while
>> executing this line:
>> C:\netbeans\nbbuild\build.xml:685: The following error occurred while
>> executing this line:
>> C:\netbeans\nbbuild\templates\common.xml:206: Compile failed; see the
>> compiler error output for details.
>>
>> On a separate note...
>> However I was thinking maybe my depends may not be right. Presently I
>> have
>>
>> nb.cluster.python.depends=\
>> ${clusters.config.platform.list},\
>> nb.cluster.ide,\
>> nb.cluster.nb
>>
>> But not sure if that's overkill. Any recommendations on these?
>>
>>
>> Eric Bresie
>> [email protected]
>>
>>
>> On Mon, Dec 28, 2020 at 1:20 PM Eric Bresie <[email protected]> wrote:
>>
>>> Pulled down the contrib from mercurial repository [2] with the ant build
>>> version and am getting further.
>>>
>>> I did encounter an Out of Memory so setting heap size as mentioned
>>> elsewhere [3]
>>>
>>> This is the first time I've done a full build in this workspace area
>>> so having to compile a lot of basic IDE and platform modules as well.
>>>
>>> I'm on a slow machine so will have to wait and see what the outcome is.
>>> More to follow.
>>>
>>> Eric Bresie
>>> [email protected]
>>> [2] http://hg.netbeans.org/main/contrib/
>>> [3] http://wiki.netbeans.org/WorkingWithNetBeansSources
>>>
>>>
>>> On Mon, Dec 28, 2020 at 9:45 AM Laszlo Kishalmi <
>>> [email protected]> wrote:
>>>
>>>> About the build: Use Option 1, non-mavenize. That shall be fairly easy.
>>>>
>>>> On 12/28/20 7:39 AM, Eric Bresie wrote:
>>>> > I may have found the main source of my problems...
>>>> >
>>>> > I started with netbeans-contrib version from Tim [1] which is maven
>>>> based.
>>>> >
>>>> > Is there any use case where some of the code is maven based and built
>>>> with
>>>> > the top level ant build infrastructure?
>>>> >
>>>> > More specific details...
>>>> >
>>>> > I merged and move stuff out of contrib into a top level python cluster
>>>> > folder at the same level as others (i.e. cpp-lite, php, groovy, etc.)
>>>> with
>>>> > all the related sub-projects (jython and python) underneath. I
>>>> updated
>>>> > the cluster.properties files and was continuing to get the build
>>>> issues.
>>>> >
>>>> > I finally realized the netbeans-contribute version I pulled may have
>>>> been a
>>>> > “proof of concept” to convert over to maven based build versions of
>>>> the
>>>> > contrib projects. And as such there are no ant equivalent build files
>>>> > present there. So assume because of this the ant build doesn’t know
>>>> how to
>>>> > handle these.
>>>> >
>>>> > I tried building one of the modules with maven and it built fine...
>>>> >
>>>> > Since the main build is presently utilizing ant, is there a way to
>>>> have the
>>>> > ant build pick up a maven sub projects build?
>>>> >
>>>> > Would it be better to
>>>> > (1) attempt to retrieve the “non-mavenized” version and merge that one
>>>> > instead? My hesitation is I thought Tim had made some updates along
>>>> the
>>>> > way beyond just mavenizing but I may be wrong there.
>>>> > (2) implement some build logic to allow mixture of ant/maven builds
>>>> > (3) wait for the “maven” based Netbeans builds in development
>>>> > (4) recreate python as a new LSP client language (and/or kind of a
>>>> > python-lite similar to cpp-lite)?
>>>> >
>>>> > Specific question on the architecture of the python projects. Are the
>>>> > jython and python sub-project independent of each other? Or are the
>>>> coupled
>>>> > in some way? Just trying to see if this would really be two different
>>>> > flavors of support or if they should be packaged together and/or need
>>>> to be
>>>> > together.
>>>> >
>>>> > Regarding build artifact/dependencies..
>>>> >
>>>> > While reviewing the maven version Pom file for o.jython and it was not
>>>> > finding the dependencies quite as expected as it was looking under
>>>> Central
>>>> > Repository: org/netbeans (apache.org)
>>>> > <https://repo.maven.apache.org/maven2/org/netbeans/> for which there
>>>> > appears to be no such jython or python dependencies there. I believe
>>>> > previous ones may have been picked up but still I was
>>>> wondering...Given the
>>>> > move to Apache and not fully being donated/integrated, am I correct in
>>>> > saying these dependencies are no longer published there? And if not,
>>>> what
>>>> > would need to be done to get the proper dependencies published? Is
>>>> this a
>>>> > matter of once integrated and start getting including in the master
>>>> source
>>>> > repository allowing the jars to be built they would then start being
>>>> > publishers there? Have these dependencies been moved elsewhere?
>>>> >
>>>> > I see some jython dependencies available under Central Repository:
>>>> > org/python (apache.org) <
>>>> https://repo.maven.apache.org/maven2/org/python/> so
>>>> > assuming maybe it may require usage of some of these in some way but
>>>> that’s
>>>> > just a guess.
>>>> >
>>>> > Were these published by the jython/python developers and should not
>>>> be part
>>>> > of NB build context?
>>>> >
>>>> > [1] timboudreau/netbeans-contrib: Fork of netbeans contrib repo (
>>>> github.com)
>>>> > <https://github.com/timboudreau/netbeans-contrib>
>>>> >
>>>> > Eric
>>>> >
>>>> > On Mon, Dec 21, 2020 at 12:48 AM Jaroslav Tulach <
>>>> [email protected]>
>>>> > wrote:
>>>> >
>>>> >> Hello Eric,
>>>> >> thanks for taking care of porting Python support to Apache NetBeans.
>>>> Your
>>>> >> work shall not be lost. The sources are supposed to be part of next
>>>> >> donation to Apache, it is just taking ages to get the approvals. We
>>>> are
>>>> >> missing the driving force of Geertjan...
>>>> >>
>>>> >>> nb.cluster.python.dir=python
>>>> >>> nb.cluster.python.depends=\
>>>> >>> nb.cluster.ide
>>>> >>> nb.cluster.python=\
>>>> >>> o.jython,\
>>>> >>> o.jython.distro,\
>>>> >>> python.console,\
>>>> >>> python.core,\
>>>> >>> python.debugger,\
>>>> >>> python.editor,\
>>>> >>> python.help,\
>>>> >>> python.hints,\
>>>> >>> python.kit,\
>>>> >>> python.options,\
>>>> >>> python.platform,\
>>>> >>> python.project,\
>>>> >>> python.project2,\
>>>> >>> python.samples,\
>>>> >>> python.source,\
>>>> >>> python.testrunner
>>>> >> Right, creating own cluster (like php) is good idea.
>>>> >>
>>>> >>> C:\git\netbeans.ebresie\netbeans\python\o.jython
>>>> >> This is the right location for the files. Try to go into that
>>>> directory and
>>>> >> use `ant build` in there. Once the projects compile one by one, we
>>>> can try
>>>> >> to analyze the failure when compiling the whole cluster. Just 2Kč
>>>> advice...
>>>> >> -jt
>>>> >> so 19. 12. 2020 v 16:23 odesílatel Eric Bresie <[email protected]>
>>>> napsal:
>>>> >>
>>>> >>> Maybe someone familiar with the python project can chime in...
>>>> >>>
>>>> >>> After a few further tweaks in the cluster.properties file I still
>>>> >> continue
>>>> >>> to get
>>>> >>>
>>>> >>> $ ant -Dcluster.config=python | tee >> build.output.txt
>>>> >>> [copy] Warning: Could not find file
>>>> >>> <>\netbeans\nbbuild\gitinfo.properties to copy.
>>>> >>> [copy] Warning: Could not find
>>>> >>> file <>\\netbeans\nbbuild\netbeansrelease.properties to copy.
>>>> >>>
>>>> >>> BUILD FAILED
>>>> >>> <>\\netbeans\nbbuild\build.xml:277: Cannot resolve python/o.jython.
>>>> >> Neither
>>>> >>> one exist:
>>>> >>> <>\\netbeans\python\o.jython
>>>> >>> <>\\netbeans\python\python\o.jython
>>>> >>>
>>>> >>> I'm starting to think the o.jython mentioned in some way requires a
>>>> >> binary
>>>> >>> download of some jython jars which is missing and not getting pulled
>>>> >> down.
>>>> >>> In the build.xml mention of downloadbinaries associated with the
>>>> >>> nbuild\external\binaries-list. Assuming cluster specific is
>>>> defined in a
>>>> >>> cluster specific version of the "external\binaries-list". So my
>>>> thinking
>>>> >>> is somehow whatever causes the higher level to link up with the
>>>> cluster
>>>> >>> lower levels is not getting downloads correctly. Is there maybe
>>>> some
>>>> >>> configuration I might be missing here?
>>>> >>>
>>>> >>> Eric Bresie
>>>> >>> [email protected]
>>>> >>>
>>>> >>>
>>>> >>> On Fri, Dec 11, 2020 at 12:41 PM Eric Bresie <[email protected]>
>>>> wrote:
>>>> >>>
>>>> >>>> As a learning project, I am trying to get python working in
>>>> netbeans.
>>>> >>>>
>>>> >>>> One of my first steps was to make a python branch on github based
>>>> on my
>>>> >>>> fork from the main netbeans project, pulled down the contrib code
>>>> from
>>>> >>> the
>>>> >>>> hg repository including the python related projects and start
>>>> plugging
>>>> >>> away
>>>> >>>> at it.
>>>> >>>>
>>>> >>>> The files for the project used to be located under contrib/python
>>>> (and
>>>> >>>> jython)" but I thought if acceptable, might be better to move it
>>>> into a
>>>> >>>> "top level" project (similar to php). As part of this, I moved the
>>>> >>> folders
>>>> >>>> and started updating the clusters.properties file to add applicable
>>>> >>> python
>>>> >>>> items and to move out of the other area so the current iteration of
>>>> >> this
>>>> >>>> looks like:
>>>> >>>>
>>>> >>>> nb.cluster.python.dir=python
>>>> >>>> nb.cluster.python.depends=\
>>>> >>>> nb.cluster.ide
>>>> >>>> nb.cluster.python=\
>>>> >>>> o.jython,\
>>>> >>>> o.jython.distro,\
>>>> >>>> python.console,\
>>>> >>>> python.core,\
>>>> >>>> python.debugger,\
>>>> >>>> python.editor,\
>>>> >>>> python.help,\
>>>> >>>> python.hints,\
>>>> >>>> python.kit,\
>>>> >>>> python.options,\
>>>> >>>> python.platform,\
>>>> >>>> python.project,\
>>>> >>>> python.project2,\
>>>> >>>> python.samples,\
>>>> >>>> python.source,\
>>>> >>>> python.testrunner
>>>> >>>>
>>>> >>>> However, when attempting to build with
>>>> >>>>
>>>> >>>> ant clean -Dcluster.config=python build
>>>> >>>>
>>>> >>>>
>>>> >>>> I get an error like:
>>>> >>>>
>>>> >>>> BUILD FAILED
>>>> >>>> C:\git\netbeans.ebresie\netbeans\nbbuild\build.xml:1313: The
>>>> following
>>>> >>>> error occurred while executing this line:
>>>> >>>> C:\git\netbeans.ebresie\netbeans\nbbuild\build.xml:277: Cannot
>>>> resolve
>>>> >>>> o.jython. Neither one exist:
>>>> >>>> C:\git\netbeans.ebresie\netbeans\o.jython
>>>> >>>> C:\git\netbeans.ebresie\netbeans\python\o.jython
>>>> >>>>
>>>> >>>> I tried in another form with the non-jython items and then it
>>>> moved on
>>>> >> to
>>>> >>>> the next module so I think for some reason it is not finding the
>>>> >> modules
>>>> >>>> under ".dir" attribute defined above for some reason. I moved the
>>>> >> python
>>>> >>>> and jython related projects under a "python" top level folder which
>>>> >>> assumed
>>>> >>>> it should find but for some reason
>>>> >>>>
>>>> >>>> Anyone have any idea how to resolve this problem?
>>>> >>>>
>>>> >>>> Eric Bresie
>>>> >>>> [email protected]
>>>> >>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [email protected]
>>>> For additional commands, e-mail: [email protected]
>>>>
>>>> For further information about the NetBeans mailing lists, visit:
>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>
>>>>
>>>>
>>>>
