so 2. 1. 2021 v 18:57 odesílatel Eric Bresie <[email protected]> napsal:
> Eric Bresie > [email protected] > > > On Thu, Dec 31, 2020 at 12:40 AM Jaroslav Tulach < > [email protected]> > wrote: > > > st 30. 12. 2020 v 19:19 odesílatel Eric Bresie <[email protected]> > napsal: > > > > > There also seems to be failure on ergonomics tests like the below but > I'm > > > not sure why this is happening. Maybe a failure elsewhere. > > > > No, it is not failure elsewhere. It is failure caused by your integration > > of new project type. > > > > Please find more info here: > > > > > http://wiki.netbeans.org/FitnessForever#Static_Analysis_and_Dynamic_Verification > > > EB ==> Reviewing this... > EB ==> Is it the case the "real IDE" may have similar dependencies with > Python dependencies causing > EB ==> conflict during this test? > EB ==> Is it implying favoring IDE over module dependencies? > > EB ==> Or is the issue against one of the test cases list assumed from > above it could be... > > New Project wizard Extracted from Layers All templates attributes need to > be correct > > > > EB ==> If this is the case, how does this need to be done? > EB ==> (1) When I ran in my build locally it had the python projects so I'm > unclear beyond that. > EB ==> (2) Are these templates associated with a python project? > EB ==> (3) Some change to a configuration of templates elsewhere? > > EB ==> Or this: > > > - *Verify* - commit validation contains a test that compares the data > seen by the real IDE and the *ergonomics* IDE and verifies that they > match as expected. > > EB ==> So how does this get resolved? > EB ==> (1) What data is being compared here? > EB ==> (2) Does this require a unit test update? > EB ==> (3) Does this require "test configuration data" (i.e. add "python" > into the configuration) to be updated? > It would easier for me to fix the problem, than answer your questions! I three possible options: - dig the git history of ergonomics/ide.ergonomics module to find out what others have done - use debugger to see what DynamicVerifyTest does - if the above fail, pair programming over zoom may help -jt > > [junit] WARNING [org.netbeans.TopSecurityManager]: use of system > > property netbeans.home has been obsoleted in favor of > > InstalledFileLocator/Places at > > > > > > org.netbeans.modules.ide.ergonomics.CommonServersBase.doGetAllInstancesErgo(CommonServersBase.java:90) > > 10108 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]: > > Iterating ergo > > 10109 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]: > > ergo: Amazon Beanstalk > > 10110 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]: > > Iteration done for ergo > > *10111 [junit] Test > > org.netbeans.modules.ide.ergonomics.DynamicVerifyTest FAILED* > > 10112 [junit] Dec 30, 2020 5:38:14 PM > > org.netbeans.core.startup.NbEvents logged > > 10113 [junit] INFO: Warning - could not install some modules: > > 10114 [junit] org.netbeans.modules.editor.lib2 - No module > > providing the capability org.netbeans.modules.editor.actions could be > > found. > > 10115 [junit] org.netbeans.modules.editor.lib - The module > > org.netbeans.modules.editor.lib2 would also need to be installed. > > > > > > BUILD FAILED > > 10234/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:723: > > The following error occurred while executing this line: > > 10235/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:716: > > The following error occurred while executing this line: > > 10236/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:750: > > The following error occurred while executing this line: > > 10237/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:747: > > Some tests failed; see details above. > > 10238 > > 10239Total time: 1 minute 24 seconds > > 10240The command "ant $OPTS -f ergonomics/ide.ergonomics test > > -Dtest.config=commit" exited with 1. > > > > Eric Bresie > > [email protected] > > > > > > On Wed, Dec 30, 2020 at 12:03 PM Eric Bresie <[email protected]> wrote: > > > > > Okay after some synching with upstream and ovecoming some apparent > github > > > pr isms ...I have created a "draft PR" available at > > > https://github.com/apache/netbeans/pull/2622 > > > > > > However, it looks that some of the CI checks are failing as I kind of > > > expected. > > > > > > Some seem to be related to licensing like the below. > > > > > > I assume some of this has to do with > > > (1) Jython license details being missing, > > > (2) Some "Oracle" licensing being present (assume this may be part of > the > > > donation process being worked), and some > > > (3) Failure to document licenses in applicable locations > > > (4) License formatting issues > > > > > > Can anyone familiar with handling licensing provide some input on how > to > > > handle these? > > > > > > Build licensing issues > > > (1) This: > > > > > > verify-libs-and-licenses: > > > 1226[verifylibsandlicenses] > > > /home/travis/build/apache/netbeans/nbbuild/build/verifylibsandlicenses.xml: > > 3 failures out of 5 tests > > > 1227 > > > 1228BUILD FAILED > > > 1229/home/travis/build/apache/netbeans/nbbuild/build.xml:1642: Failed > > VerifyLibsAndLicenses test(s): > > > 1230Some binaries were found outside of <module>/external/ directories > > (edit nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binaries as > > needed) > > > > > > > 1231python/python.samples/src/org/netbeans/modules/python/samples/JySwingProject.zip > > > > > > > 1232python/python.samples/src/org/netbeans/modules/python/samples/PLYDemoProject.zip > > > > > > > 1233python/python.samples/src/org/netbeans/modules/python/samples/PyThreadsProject.zip > > > 1234Some license files were badly formatted > > > 1235python/o.jython.distro/external/jython-2.7.0-license.txt has a > > trailing space on line #61 > > > 1236Some license files have incorrect headers > > > 1237python/o.jython/external/jython-parser.jar does not appear to > > include a version number > > > 1238python/o.jython/external/jython-parser.jar is not associated with > > any license file > > > 1239python/o.jython.distro/external/jython-2.7.0-license.txt refers to > > nonexistent nbbuild/licenses/Jython > > > 1240python/python.editor/external/preindexed.zip does not appear to > > include a version number > > > 1241python/python.editor/external/preindexed.zip is not associated with > > any license file > > > 1242 > > > 1243Total time: 1 minute 30 seconds > > > 1244The command "ant verify-libs-and-licenses > > -Dverify-libs-and-licenses.haltonfailure=true -Dmetabuild.jsonurl= > > > > https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json > " > > exited with 1. > > > > > > <https://github.com/apache/netbeans/pull/2622> > > > > > > (2) And like this > > > > > > BUILD FAILED > > > 550/home/travis/build/apache/netbeans/scratch/nbbuild/build.xml:2227: > > Failed Rat test(s): > > > 551Unapproved license in 549 file(s) > > > 552 > > > > https://github.com/apache/netbeans/tree/master/python/python.debugger/src/org/netbeans/modules/python/debugger/config/NetBeansFrontend.java > > > 553 > > > > https://github.com/apache/netbeans/tree/master/python/python.project/src/org/netbeans/modules/python/project/ui/actions/RunSingleCommand.java > > > 554 > > > > https://github.com/apache/netbeans/tree/master/python/python.editor/src/org/netbeans/modules/python/editor/wizards/pypackage/PythonPackageWizardIterator.java > > > > > > > > > > > > Eric Bresie > > > [email protected] > > > > > > > > > On Tue, Dec 29, 2020 at 12:28 PM Eric Bresie <[email protected]> > wrote: > > > > > >> Okay...I was able to get it to compile and run successfully. Haven't > > >> done too much testing yet but seems in good shape so far. > > >> > > >> Assume this may be in support of NETBEANS-4538 > > >> > > >> So wanted to see what may be needed to go forward with this. > > >> > > >> It is still unclear to be about > > >> (1) How to handle the missing files mentioned earlier (see earlier > email > > >> for more specifics) > > >> (2) Is there expected to be any further "donation" activities which > may > > >> make some of this be overcome by other updates coming down the line? > > >> (3) Is Oracle/Apache legal still working anything prior to acceptance? > > >> (4) Since much of this is derived from the nbpython project, is there > > any > > >> concerns from the nbpython project team? > > >> a) I've had difficult contacting anyone due to stale or > > >> inaccessible web sites or comms means > > >> b) I'm hoping some folks on the list may be able to help here > > >> (5) What needs to be done to include this incoming > > >> build/release/milestone/components/etc.? > > >> > > >> Assume one of the first steps would be check in and raise a PR but due > > to > > >> my inexperience in this sort of major git activities, I may need some > > help > > >> on this as I don't believe what I've done so far is quite right. > > >> > > >> When pushing my local "python" branch changes to my fork (see > > >> https://github.com/ebresie/netbeans) on a remote "python" branch > there > > >> was a mixture of activities going on at the same time when trying to > > check > > >> some of this stuff in. Specifically there were changes including (1) > > >> periodic upstream merge of recent change, (2) a separate cnd > > >> activities[which should have been a separate branch but unfortunately > > got > > >> included with previous updates] , and (3) mixture of maven vs > non-maven > > >> python versions. > > >> > > >> So all that is to say, this makes creating a PR rather difficult.. > How > > >> can I reconcile these issues in support of PR creation? Is there a > way > > to > > >> exclude these sorts of things in github PR (i.e. can I somehow delete > > the > > >> other commits)? Do I need some squashed or some other git activities? > > Do > > >> I need to somehow revert back to state prior to python getting merged > > and > > >> without the "cnd" inclusion and then somehow merge the python changes > in > > >> some way on a fresh attempt? Git help is appreciated. > > >> > > >> Eric Bresie > > >> [email protected] > > >> > > >> > > >> On Mon, Dec 28, 2020 at 8:30 PM Eric Bresie <[email protected]> > wrote: > > >> > > >>> Also in the python.editor module, in the scripts is a missing > > >>> "coverage.py" file as well. > > >>> > > >>> I believe this is related to > > >>> http://nedbatchelder.com/code/modules/coverage.html > > >>> Or more recently https://coverage.readthedocs.io/en/latest/ > > >>> > > >>> Assume this one may be left out on purpose. Assume can either (1) > > >>> remove references to it elsewhere (where it's getting copied), (2) > > find a > > >>> way to "import" as an external element of some type or (3) replace it > > in > > >>> some other way. > > >>> > > >>> Eric Bresie > > >>> [email protected] > > >>> > > >>> > > >>> On Mon, Dec 28, 2020 at 6:56 PM Eric Bresie <[email protected]> > wrote: > > >>> > > >>>> Okay...after a few failed attempts and a few more tweaks (I had to > > >>>> change the location in the build.xml for each of the projects to > > point to > > >>>> the python cluster subdirectory)...I was finally able to get it to > > build up > > >>>> to a point... > > >>>> > > >>>> However ended with errors like the below. > > >>>> > > >>>> Seems > > >>>> > > > > C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java > > >>>> depends on org.netbeans.modules.python.debugger.utils.MiscStatic > which > > >>>> appears to not be present. Did this get left out in the donation? > I > > don't > > >>>> see it in the hg.netbeans.org main/contrib version of this but do > > find > > >>>> it in the maven version. > > >>>> > > >>>> Also seems to be missing package > > >>>> org.netbeans.modules.python.source.scopes (also found in the maven > > version) > > >>>> with which includes but not limited to classes like SymbolTable and > > >>>> SymInfo. Are these the sort of files that may get removed as part > of > > >>>> donation and/or IP sanitizing of the donation? > > >>>> > > >>>> -do-compile: > > >>>> [nb-javac] Compiling 75 source files to > > >>>> C:\netbeans\python\python.debugger\build\classes > > >>>> [repeat] warning: [options] bootstrap class path not set in > > >>>> conjunction with -source 7 > > >>>> [repeat] > > >>>> > > > > C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory > > >>>> in org.xml.sax.helpers has been deprecated > > >>>> [repeat] import org.xml.sax.helpers.XMLReaderFactory; > > >>>> [repeat] ^ > > >>>> [repeat] > > >>>> > > > > C:\git\netbeans.ebresie\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java > > >>>> [repeat] import > > >>>> org.netbeans.modules.python.debugger.utils.MiscStatic; > > >>>> [repeat] ^ > > >>>> [repeat] symbol: class MiscStatic > > >>>> [repeat] location: package > > >>>> org.netbeans.modules.python.debugger.utils > > >>>> [repeat] > > >>>> > > > > C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory > > >>>> in org.xml.sax.helpers has been deprecated > > >>>> [repeat] import org.xml.sax.helpers.XMLReaderFactory; > > >>>> [repeat] ^ > > >>>> [repeat] 1 error > > >>>> [repeat] 3 warnings > > >>>> [nbmerge] Failed to build target: all-python.debugger > > >>>> > > >>>> BUILD FAILED > > >>>> C:\netbeans\nbbuild\build.xml:643: The following error occurred > while > > >>>> executing this line: > > >>>> C:\netbeans\nbbuild\build.xml:638: The following error occurred > while > > >>>> executing this line: > > >>>> C:\netbeans\nbbuild\build.xml:685: The following error occurred > while > > >>>> executing this line: > > >>>> C:\netbeans\nbbuild\templates\common.xml:206: Compile failed; see > the > > >>>> compiler error output for details. > > >>>> > > >>>> On a separate note... > > >>>> However I was thinking maybe my depends may not be right. Presently > I > > >>>> have > > >>>> > > >>>> nb.cluster.python.depends=\ > > >>>> ${clusters.config.platform.list},\ > > >>>> nb.cluster.ide,\ > > >>>> nb.cluster.nb > > >>>> > > >>>> But not sure if that's overkill. Any recommendations on these? > > >>>> > > >>>> > > >>>> Eric Bresie > > >>>> [email protected] > > >>>> > > >>> > > >
