> So, was there any specific tech reason to not use the bin/netbeans script? > or did you just happen to find yourself at nbexec when you were done?
I looked at the Windows native launcher code and what the netbeans script did and decided to implement similar logic in the Swift code. > Do you think there might be a problem later with switching over to > bin/netbeans? No, I've pushed a new PR https://github.com/apache/netbeans/pull/2717 that updates the logic to just call the netbeans script. > On that note, though, if this wrapper works, and works now, and we're that > close to 12.3, I would think it's worth having this capability in 12.3 now, > and fix it for bin/netbeans after the release, rather than removing the > capability from 12.3, or holding it up. I've been using the launcher from my original PR since 12.2 was released and John tested it during his PR review. Given we have already frozen 12.3, I imagine it would be better to wait for 12.4 on my new PR #2717. > So, how do we test this, and make sure it's working properly for 12.3 > before we get out of beta? Any macOS user could test the launcher using their NetBeans 12.2 installation by replacing the symlink (to the shell script) with the native launcher. 1. Install Xcode if not already installed. 2. Compile the swift launcher. cd nb/ide.launcher/macosx swift build -c release 3. Replace launcher. sudo mv /Applications/NetBeans/Apache\ NetBeans\ 12.2.app/Contents/MacOS/netbeans /Applications/NetBeans/Apache\ NetBeans\ 12.2.app/Contents/MacOS/netbeans.old sudo cp .build/x86_64-apple-macosx/release/NetBeansLauncher /Applications/NetBeans/Apache\ NetBeans\ 12.2.app/Contents/MacOS/netbeans 4. Launch Netbeans --Christian On Thu, Jan 28, 2021 at 12:21 PM Will Hartung <[email protected]> wrote: > On Thu, Jan 28, 2021 at 8:50 AM Neil C Smith <[email protected]> > wrote: > > > It's not invoking Java directly though, just the next script in the > > chain at > > > https://github.com/apache/netbeans/blob/master/platform/o.n.bootstrap/launcher/unix/nbexec > > > > So, was there any specific tech reason to not use the bin/netbeans script? > or did you just happen to find yourself at nbexec when you were done? > > Do you think there might be a problem later with switching over to > bin/netbeans? > > Regards, > > Will Hartung >
