On Thu, 28 Jan 2021 at 23:09, Christian Oyarzun <[email protected]> wrote: > No, I've pushed a new PR https://github.com/apache/netbeans/pull/2717 that > updates the logic to just call the netbeans script. ... > I looked at the Windows native launcher code and what the netbeans script > did and decided to implement similar logic in the Swift code.
Thanks for the updated PR. I've commented also there, but my concerns are not just about duplicating logic, but also because this is unlike the Windows launchers. They are also used in the zip bundle, and so in daily builds, betas, etc. I'd have less concern if this was the case here, but having two ways to launch, one less likely to be used by devs or in testing, also feels problematic. Of course, finding a way to get the installers in beta testing without manual work would be good too! And I'm wondering if Windows scripting is more capable of working the same way these days?! :-) > I've been using the launcher from my original PR since 12.2 was released > and John tested it during his PR review. > Given we have already frozen 12.3, I imagine it would be better to wait for > 12.4 on my new PR #2717. That's good, let's keep what we have in the release branch for 12.3. > Any macOS user could test the launcher using their NetBeans 12.2 > installation by replacing the symlink (to the shell script) with the native > launcher. ... Thanks for that. Along with John's offer on a beta installer, hopefully we're well covered for testing prior to release. Thanks and best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
