Dne neděle 14. února 2021 13:55:47 CET, Neil C Smith napsal(a): > -1 (binding)
Hello Neil, your vote will be counted. Now moving the discussion to [DISCUSS] thread. > Firstly, agree with Matthias, that this was not the way to handle > this, we shouldn't be rubberstamping, and there were other mitigating > steps that were available while a release was put through, as well as > options for prioritising. It is my desire to make sure 12.2.2 release is kosher as soon as possible. As I wrote in other reply, I am convinced that I haven't done anything wrong by starting the vote. > Alongside that, there are a number of issues here - > > There is no entry in > https://github.com/apache/netbeans-jenkins-lib/blob/master/meta/netbeansrele > ase.json which means that dev is written in to the release information in > the source bundle. Not a showstopper, but far from ideal - this affects > module implementation versions. Is this something one should fix when preparing a release? I haven't done that in 12.2.1 neither when preparing current 12.2.2 - is there a checklist to follow to avoid this error next time? Btw. good to hear it is not seen as a showstopper. > More importantly, there's something awry with the binary build > process. I checked against 12.2.1 and 12.2.2, because the former if > built from the source bundle should have been picking up the correct > UC by the look of netbeansrelease.properties. Are you saying the `.vsix` convenience binary selects wrong (development build) update center because the build process is wrong? It is in my interest to fix it to avoid similar error next time. > According to the ci-build the binary here was built from branch > refs/remotes/origin/jtulach/VSNetBeansBackport2757 rather than > release122. The git branch info is then not found (although this also > might be a build from tag issue), and the build will not match a build > from the source bundle. It looks like a similar issue affected > 12.2.1, which is why the wrong UC got written into it amongst other > things. Yup. That's what I did. I didn't realize our build is "branch sensitive"! That's not very common among software projects. Usually it is enough to ``` $ git checkout 1fb82a99c5e633 ``` and the build result is going to match build from 12.2.2 tag or state of release122 branch as soon as 1fb82a99c5e633 is made tip of the release122 branch. > It does look like the git hash is correct, Of course, it is correct! > although presumably because > of a fast forward commit to the release branch? Not using PRs is > fine, but there should still be a merge commit, as it's the hashes of > those on the release branches used to mark releases. Merge commit isn't needed if one stacks the new commits on top of 12.2.1 tag the way I did it. Then it is just about moving the release122 branch forward on the 1fb82a99c5e633 commit. > The build process will need correcting for 12.3, even if we let this > pass - quickest is probably passing -Dmetabuild.branch=release12* (and > possibly even metabuild.hash) as and until we can get the build for > this integrated with the rest in the main build? Integrating the `.vsix` build into the main build would be great! Enough to `ant build && ant -f java/java.lsp.server/ build-vscode-ext` and record the resulting `**/*.vsix` file! -jt PS: I am not sure what you mean: > Aside from that, I noticed the hard removal of poi .m2 artefacts in > the Jenkins script - this is no longer required, and possibly not > something we should be doing? running ``` $ git diff 12.2.1...12.2.2 | grep m2 ``` yields nothing. > On Sun, 14 Feb 2021 at 05:52, Jaroslav Tulach <[email protected]> wrote: > > Dear community, > > please accept my apology for this emergency vote. The work on release 12.3 > > revealed a problem with autoupdate catalogs (see > > https://github.com/apache/netbeans/pull/2757) which prevents existing > > Apache NetBeans VSCode Extension to launch properly. That renders it > > useless for all its early adopters and may negatively impact their > > experience when using our technology. As such I have backported the > > necessary changes, tagged them and I am calling for a vote for 12.2 u2 > > emergency update: > > > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbea > > ns-vscode-ext-12.2.2/netbeans-12.2.2-source.zip > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbe > > ans-vscode-ext-12.2.2/netbeans-12.2.2-source.zip.asc > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbe > > ans-vscode-ext-12.2.2/netbeans-12.2.2-source.zip.sha512 > > > > The sources are associated with a convenience binary containing the VSCode > > extension file > > for Apache NetBeans Language Server 12.2.2 extension: > > > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbea > > ns-vscode-ext-12.2.2/apache-netbeans-java-12.2.2.vsix > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbe > > ans-vscode-ext-12.2.2/apache-netbeans-java-12.2.2.vsix.asc > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbe > > ans-vscode-ext-12.2.2/apache-netbeans-java-12.2.2.vsix.sha512 > > > > The source ZIP as well as the `.vsix` file come from tag 12.2.2 in our > > repository: https://github.com/apache/netbeans/tree/12.2.2 - e.g. from > > commit 1fb82a99c5e633. The source ZIP has been produced by running `ant > > build-source-config`. The `.vsix` file has been produced by > > https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/290/ job > > run. > > Both artifacts were signed by my 2021 GPG key. > > > > To build the Apache NetBeans Language Server extension please follow the > > instruction in [java/java.lsp.server/vscode/BUILD.md](https://github.com/ > > apache/netbeans/blob/c8e0cec5edcbfbd61f22e07eb92fcdbad17f345b/java/ > > java.lsp.server/vscode/BUILD.md), e.g.: > > > > ```bash > > netbeans$ ant build > > netbeans$ cd java/java.lsp.server > > java.lsp.server$ ant build-vscode-ext > > ``` > > > > To test the resulting convenience `.vsix` file, please follow the [wiki > > page](https://cwiki.apache.org/confluence/display/NETBEANS/ > > Apache+NetBeans+extension+for+Visual+Studio+Code) instructions that > > describe > > the typical scenarios the extension is supposed to support. > > > > > > Let's the testing and voting start! > > -jt > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
