Regarding the parser, is that a candidate to replace with an LSP implementation?
Eric Bresie ebre...@gmail.com (mailto:ebre...@gmail.com) > On March 17, 2021 at 1:34:24 AM CDT, antonio <anto...@vieiro.net > (mailto:anto...@vieiro.net)> wrote: > Hi, > > Yep, in order to get things compiling I uploaded the old NetBeans 8.2 > binary of the non-donated parser to OSOUL [1] a while back. I thought we > could use that binary temporarily to speed up things (it's CDDL'd after > all). > > But as Laszlo says it would be good to understand what the module does > and build a parser from scratch. Note that C++ has evolved a lot since > 8.2 days, so I assume we'll have to update the parser with latest C++ > features. > > I think it's ok to look at the old repository to know _what_ the module > does, but of course we can't just copy the sources of non-donated > modules (GPL+CPE/CDDL) and just paste them in an Apache Licensed > project. This is strictly forbidden. I'd go with a clean-room > implementation as Laszlo suggests. > > A while back I opened this issue: > > https://issues.apache.org/jira/browse/NETBEANS-4619 > > to track the problems I was finding with the CND donation. When > something was missing or not implemented I simply added some source that > throws an Exception, added a subtask to NETBEANS-4619 to track what the > problem was and kept-on trying to compile the cnd cluster. > > Also there's a branch in my repo you may want to take a look at: > > https://github.com/vieiro/netbeans/tree/issues/NETBEANS-4619 > > This does compile several modules in the cnd cluster. You can try to > clone that branch and run "ant -Dcluster.config=cnd" to see how far I > got there. > > I may be able to upload some more commits to that branch with a > compilable version of "cnd.modelimpl". I'm currently stuck in finding > the license info for the "open-fortran-parser-0.7.1.2.zip" file. Next > module in the dependency tree seems to be the "cnd.remote" which seems > to need a "cnd-rfs-1.0-zip" file (no idea what this does, though). > > So, to summarize: > > - We can get going with the 8.2 parser binary for compilation. Even for > release. It would be nice to have a new parser implementation. > - There's a lot of research to be done finding third-party licenses, > seeing if they're compatible, uploading them to OSOUL and adding the > proper entries in external/binaries-list, with a companion txt file that > explains the license of the dependency (see [1] for an example). > - Once the "cnd" cluster compiles we should go take a look at > NETBEANS-4619 to find-out what needs a new implementation. > > I hope this clarifies, let me know any questions you may have. > > Kind regards, > Antonio > > [1] > The missing parser module is > "org-netbeans-modules-cnd-antlr-RELEASE82.jar.txt". > > In my NETBEANS-4619 branch I added the binary to OSOUL and to the > "binaries-list" file here: > > https://github.com/vieiro/netbeans/blob/issues/NETBEANS-4619/cnd/libs.antlr.cnd/external/binaries-list > > https://github.com/vieiro/netbeans/blob/issues/NETBEANS-4619/cnd/libs.antlr.cnd/external/org-netbeans-modules-cnd-antlr-RELEASE82.jar.txt > > > El 16/3/21 a las 23:37, Laszlo Kishalmi escribió: > > Well, as far as I checked the non donated parser was a mostly generated, > > then customized code. I can understand why the license was not clear. > > The best thing would be if we can re-implement that module, by > > generating a parser from the source and implementing the required glue > > around that. Though it requires deep knowledge and time... > > > > On 3/16/21 3:14 PM, Tristan Lewis wrote: > > > With the non-donated parts, should we try to ascertain the state of > > > their licenses? It seems we can access the original files - either > > > through the old repository or via java de-compiling. > > > > > > I think getting it to compile without requiring modification should be > > > the first goal. I would think that reviewing changes from where the > > > branch is currently towards getting it compiling is worthwhile to > > > ensure we are tracking any work that we are necessitating by having > > > functions that need to be implemented etc. > > > > > > Having a pull request to look at might be a good way to get the ball > > > rolling. > > > > > > Tristan > > > > > > ________________________________ > > > From: antonio <anto...@vieiro.net (mailto:anto...@vieiro.net)> > > > Sent: Wednesday, 17 March 2021 03:31 > > > To: dev@netbeans.apache.org (mailto:dev@netbeans.apache.org) > > > <dev@netbeans.apache.org (mailto:dev@netbeans.apache.org)> > > > Subject: Re: CND integration status > > > > > > Hi all, > > > > > > I did a first contact with CND a while back and I'm afraid we'll have to > > > do some extra effort here. Some findings: > > > > > > 1.- There's a parser module that was not donated. Simplest thing to do > > > is to use the original one released under the GPL/CDDL license. This is > > > already in the "/binaries" OSUOSL. > > > > > > 2.- Some other parts were not donated either. Simplest thing to do is to > > > implement APIs with some sensible defaults in order to compile things, > > > then implement them once things build. > > > > > > 3.- This is a big cluster and I'm not sure how to review everything. > > > Maybe the idea is to have the cluster compiling, do a review of all > > > stuff, and then proceed with fine-tuning. Thoughts? > > > > > > I think I have a branch in a laptop somewhere, maybe I can update it and > > > do a preliminar PR for review. > > > > > > Kind regards, > > > Antonio > > > > > > P.S.: I think these missing parts were not donated because of licensing > > > issues, probably because evaluating third-party licenses was too > > > complicated/impossible during the donation. > > > > > > > > > > > > On 15/03/2021 17:58, Geertjan Wielenga wrote: > > > > Recently discussed here: > > > > > > > > https://lists.apache.org/thread.html/r1e570bfba35f6a1d5cd957b794e378dd69091fa491f2247f445508ff%40%3Cusers.netbeans.apache.org%3E > > > > > > > > > > > > Gj > > > > > > > > On Mon, Mar 15, 2021 at 5:53 PM Anton V. Kirilchik > > > > <kosmonaf...@gmail.com (mailto:kosmonaf...@gmail.com)> > > > > wrote: > > > > > > > > > Hello all... > > > > > > > > > > After a big pause in C/C++ i have returned to it and found that old > > > > > NetBeans 8.2 features for C/C++ still not integrated into new > > > > > releases. > > > > > > > > > > So, i'am interesting in which status this features are now and how i > > > > > (and > > > > > may be not only i) can help in moving them into new Apache NB. > > > > > > > > > > Thanks... > > > > > > > > > > -- > > > > > Best regards, > > > > > Anton V. Kirilchik > > > > > > > > > > E-mail: kosmonaf...@gmail.com (mailto:kosmonaf...@gmail.com) > > > > > Skype: kosmonaFFFt.kav > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > > > (mailto:dev-unsubscr...@netbeans.apache.org) > > > For additional commands, e-mail: dev-h...@netbeans.apache.org > > > (mailto:dev-h...@netbeans.apache.org) > > > > > > For further information about the NetBeans mailing lists, visit: > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > > (mailto:dev-unsubscr...@netbeans.apache.org) > > For additional commands, e-mail: dev-h...@netbeans.apache.org > > (mailto:dev-h...@netbeans.apache.org) > > > > For further information about the NetBeans mailing lists, visit: > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > (mailto:dev-unsubscr...@netbeans.apache.org) > For additional commands, e-mail: dev-h...@netbeans.apache.org > (mailto:dev-h...@netbeans.apache.org) > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > >
