On Mon, May 17, 2021 at 4:15 AM Neil C Smith <[email protected]> wrote:
> +1 (binding) > > Verified hashes, signing, files, etc. > > Built with JDK 8 on Ubuntu 20.04, tested with JDK 16. > > Verified binary zip, including module versions match release git hash. > > The change between rc3 and vc1 in Java platform downloader seems a > little flaky? Few exceptions and possibly missing info? Not a reason > to hold up. > > As Tomáš mentioned, we should include these additional JARs in the > allowed list - > contents verified as OK. > > ./java/maven/test/unit/data/mavenmock/2.2/lib/fake221.jar > ./java/maven/test/unit/data/mavenmock/3.3.1/lib/fake331.jar > ./java/maven/test/unit/data/mavenmock/source.jar > ./java/maven/test/unit/data/mavenmock/3.0.5/lib/fake305.jar > ./java/maven/test/unit/data/mavenmock/4.0.0/lib/fake400.jar > > I find extra jars $ find . -name "*.jar" ./java/java.lsp.server/nbcode/branding/core/core.jar ./java/java.lsp.server/nbcode/branding/modules/org-netbeans-modules-gradle.jar ./java/java.lsp.server/nbcode/branding/modules/org-netbeans-core-windows.jar ./java/java.lsp.server/nbcode/branding/modules/org-netbeans-modules-projectui.jar ./java/java.lsp.server/nbcode/branding/modules/org-netbeans-modules-maven.jar ./java/java.lsp.server/nbcode/branding/modules/org-netbeans-modules-maven-indexer.jar ./java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar ./java/java.lsp.server/nbcode/branding/modules/org-netbeans-modules-java-j2seplatform.jar ./java/java.lsp.server/nbcode/branding/modules/org-openide-text.jar The SHA matched, it built w/JDK 11, it launched. I don't know how to vet the keys. +1 from me. Regards, Will Hartung
