I’m not an expert or PMC per say but… From code perspective it seem simple enough and looks reasonable.
It sounds like this may really be a “part 1” with a follow up issue to come is that right? Eric Bresie [email protected] (mailto:[email protected]) > On August 18, 2022 at 11:04:38 AM CDT, László Kishalmi > <[email protected] (mailto:[email protected])> wrote: > I was about to check the PR, could not find the time for that though. > > I'm sorry > > On Thu, Aug 18, 2022 at 7:02 AM Michael Bien <[email protected] > (mailto:[email protected])> wrote: > > > On 18.08.22 12:09, Neil C Smith wrote: > > > On Mon, 15 Aug 2022 at 14:21, Michael Bien <[email protected] > > > (mailto:[email protected])> wrote: > > > > So please review for correctness first, and if you review mention in the > > > > comment if you want to see this PR for 15 or 16. > > > This PR is now in rc4. > > > > > > From a releases perspective, can I add that we really need correctness > > > and suitability of base branch (eg. delivery) to be reviewed together. > > > Any reviewer can, and should if necessary, veto a merge to delivery > > > even if they're 100% happy with the code being merged to master. > > > > > > While I somewhat shared Matthias' reservations about merging for rc4, > > > as I said on the PR it would be merged if no-one else vetoed. It's > > > not the job of people doing release builds to "clear" things. > > > > agreed. That was essentially the reason for the mail, to generate a > > clear NO or YES for NB15 integration once more reviews are available. > > Unfortunately nobody said anything :( > > > > (in my mind a review approval with the comment "for NB16" would veto > > NB15 merge, a change request would "veto" the entire PR etc) > > > > -mbien > > > > > Best wishes, > > > > > > Neil > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > (mailto:[email protected]) > > > For additional commands, e-mail: [email protected] > > > (mailto:[email protected]) > > > > > > For further information about the NetBeans mailing lists, visit: > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > (mailto:[email protected]) > > For additional commands, e-mail: [email protected] > > (mailto:[email protected]) > > > > For further information about the NetBeans mailing lists, visit: > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > >
