On 22.08.24 10:50, Neil C Smith wrote:
On Thu, 22 Aug 2024 at 07:37, Michael Bien <mbie...@gmail.com> wrote:
(please indicate if this should go to delivery or master during review)
Please don't do it that way around. Or propose a change to
https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery
In particular #2 - Checking suitability of a pull request for delivery
should be part of reviewing for everyone, and a reason for requesting
changes or vetoing if really necessary.
this is a draft PR at this point with no milestone set. Based on
feedback we can set a milestone, i can rebase/retarget which is no problem.
I do agree that we should not _approve_ PRs, then retarget last minute
(without another review), but this is just a draft with no real target.
It's really important for anyone doing releases to know which branch
it's been tested and reviewed against.
yes. Right now it has no milestone -> release manager doesn't have to
worry about it yet unless the "reviewer" hat is on ;)
We've had issues there before
yes I know.
that led to that point. If it's a possible delivery candidate, open
it against delivery - reviewers can always -1 for delivery and request
it be retargeted to master.
No comment on the update as yet, although use of the Tooling API
should mean we have support of Gradle 8.10 already. Something to
check, as might be changes specifically in the tooling api itself.
right. Someone with more gradle experience would have to check those things.
best regards,
-mbien
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
