Github user emilianbold commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/2#discussion_r139602545
  
    --- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java ---
    @@ -71,7 +74,19 @@ private NbAuthenticator() {
     
         static void install() {
             if (Boolean.valueOf(NbBundle.getMessage(GuiRunLevel.class, 
"USE_Authentication"))) {
    -            setDefault(new NbAuthenticator());
    +            // Look for custom authenticator
    +            Authenticator authenticator = 
Lookup.getDefault().lookup(Authenticator.class);
    +            if (authenticator == null) {
    +                authenticator = new NbAuthenticator();
    +            }
    +            if (authenticator.getClass().equals(NbAuthenticator.class)) {
    --- End diff --
    
    Because it's not usual to log which instance you are using from the 
`Lookup`. Since this is a static situation, you know at build-time which 
instance is going to be used, unless somebody yanks your whole module with the 
other implementation out.


---

Reply via email to