Github user JaroslavTulach commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/2#discussion_r141021368 --- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java --- @@ -61,6 +63,7 @@ */ final class NbAuthenticator extends java.net.Authenticator { --- End diff -- `java.util.ServiceLoader` requires classes with public constructor so does `Lookup.getDefault()`. Is the class in public or non-public package? If it is in non-public, feel free to make its default constructor public - it won't be considered an API change anyway.
---