Sounds like a plan -- I'll use the tool to convert the licenses to Apache, push that to Git, and then we'll use Rat to narrow down the remainder.
How does that sound to everyone? Gj On Tue, 19 Sep 2017 at 08:50, Jan Lahoda <lah...@gmail.com> wrote: > I can try to categorize the files a little, but I was hoping we could > switch to using Rat to do the checks (after the bulk of the changes are > done). So if e.g. the META-INF files would be OK to not have a header, we > could simply exclude them in the Rat configuration, and they would be > ignored (but the configuration is/will be in git, so easy to review). > > As a side note, some files in the repository (typically samples) are using > 3-clause (if I get that correctly) BSD license currently, e.g.: > > https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans.git;a=blob;f=apisupport.feedreader/feedreader-suite/FeedReader/src/org/netbeans/feedreader/BrowserTopComponent.java;h=6d0a0c533a9dfa9ed81d3f4349e352d1fb49b128;hb=HEAD > > My question is what (if anything) we need to do about these. > > Thanks, > Jan > > > On Tue, Sep 19, 2017 at 6:21 AM, Geertjan Wielenga < > geertjan.wiele...@googlemail.com> wrote: > > > Does the above make sense, i.e., I'm suggesting a few ways to finetune > the > > results a bit further -- and are there other ideas for finetuning, i.e., > > trying to somehow incorporate those 14,651 files, so we can minimize the > > manual checking we'll need to do? > > > > Thanks, > > > > Gj > > > > On Mon, Sep 18, 2017 at 10:53 AM, Geertjan Wielenga < > > geertjan.wiele...@googlemail.com> wrote: > > > > > Great, I've tried it, works well. > > > > > > In the report, there's a list of 14,651 files under the heading "Files > > > without CDDL (14651)". > > > > > > Could a distinction be made between those that have a license (i.e., > some > > > license other than CDDL) and those that do not have a license at all? > > > > > > I also think that it would be nice that after that split, i.e., between > > > those with/without a license, that everything is sorted based on file > > type, > > > so we can easily distinguish those in the lists that are 'form' files, > > > 'png' files, etc, for each of these two categories. > > > > > > I think also that anything within META-INF does not have any "degree of > > > creativity", i.e, these are simply registration files for > implementations > > > of APIs. Could you provide the number of these, for this page, where > I'm > > > trying to keep a record of all the file types that are a special case > of > > > some kind: https://cwiki.apache.org/confluence/display/ > > > NETBEANS/NetBeans+Transition+Process > > > > > > Thanks a lot, and any feedback from anyone is welcome, > > > > > > Gj > > > > > > > > > > > > On Sun, Sep 17, 2017 at 5:06 PM, Jan Lahoda <lah...@gmail.com> wrote: > > > > > >> Hi, > > >> > > >> I've uploaded an updated version of the tool - fixing a bug in > rewriting > > >> headers of bundle files (where it was deleting one line after the > > header, > > >> reported by Geertjan offline), making it a little bit more strict > > >> (currently rewrites 29474 files), adding support for bat files, and > > adding > > >> ability to dump a file with statistics and changed/not changed files. > > >> > > >> I guess after the bulk update of these headers is done, and > > LICENSE&NOTICE > > >> is added, we could start a usual development? (Continuing with > reviewing > > >> the Rat report concurrently?) > > >> > > >> Could please someone overview the regexp here: > > >> https://cwiki.apache.org/confluence/display/NETBEANS/NetBean > > >> s+Transition+Process#NetBeansTransitionProcess-Toolforanalyz > > >> ingandchangingGPL+CDDLlicenseheaders > > >> > > >> to see if it is OK to write such headers? Seems OK to me personally, > > but I > > >> think having feedback from someone more experienced would be helpful. > > >> > > >> Thanks, > > >> Jan > > >> > > >> On Fri, Sep 15, 2017 at 11:43 PM, Geertjan Wielenga < > > >> geertjan.wiele...@googlemail.com> wrote: > > >> > > >> > I've used the tool, it's really great, not only analyzes but also > > >> actually > > >> > changes the licenses, 29,496 of 44,324: > > >> > > > >> > https://cwiki.apache.org/confluence/display/NETBEANS/ > > >> > NetBeans+Transition+Process > > >> > > > >> > Could the tool be tuned to list all the files that are not in the > > >> 29,496? > > >> > > > >> > I have updated the table in the link above to list all the > problematic > > >> file > > >> > types, i.e., those that are not licensed. > > >> > > > >> > Would be great to identify anything else that is not part of the > > 29,496 > > >> > that can automatically be relicensed. > > >> > > > >> > Gj > > >> > > > >> > On Thu, Sep 14, 2017 at 3:08 PM, Geertjan Wielenga < > > >> > geertjan.wiele...@googlemail.com> wrote: > > >> > > > >> > > Agree completely. > > >> > > > > >> > > Gj > > >> > > > > >> > > On Thu, Sep 14, 2017 at 3:05 PM, Jan Lahoda <lah...@gmail.com> > > wrote: > > >> > > > > >> > >> On Thu, Sep 14, 2017 at 2:59 PM, Geertjan Wielenga < > > >> > >> geertjan.wiele...@googlemail.com> wrote: > > >> > >> > > >> > >> > I think we also need to fill out the "Relicensing of > > >> > incubator-netbeans" > > >> > >> > table on the page > > >> > >> > https://cwiki.apache.org/confluence/display/NETBEANS/ > > >> > >> > NetBeans+Transition+Process, > > >> > >> > i.e., with the various file types in a column, related numbers, > > >> and in > > >> > >> each > > >> > >> > case what the problems are/could be, so that we can get a good > > >> view, > > >> > >> and a > > >> > >> > clearly documented perspective for future reference, of > > everything > > >> > that > > >> > >> > needs to be done for each type of file. > > >> > >> > > > >> > >> > > > >> > >> I was thinking of putting there files that are in some way > > >> problematic > > >> > >> (e.g. a missing license header, like in manifests). Assuming > > headers > > >> > >> matching the regexp would be OK to change, maybe we don't need to > > >> > clutter > > >> > >> the table with files that contain them (unless we have another > > >> reason to > > >> > >> put a particular file in)? (Matching headers are (unless I did > > >> something > > >> > >> wrong) in >29000 files.) > > >> > >> > > >> > >> Jan > > >> > >> > > >> > >> > > >> > >> > Gj > > >> > >> > > > >> > >> > > > >> > >> > On Thu, Sep 14, 2017 at 2:52 PM, Jan Lahoda <lah...@gmail.com> > > >> wrote: > > >> > >> > > > >> > >> > > On Mon, Sep 11, 2017 at 10:00 PM, Ate Douma <a...@douma.nu> > > >> wrote: > > >> > >> > > > > >> > >> > > > Wonderful news and big next step indeed! > > >> > >> > > > > > >> > >> > > > Now, while I understand everyone being 'trigger happy' to > > start > > >> > >> > > committing > > >> > >> > > > improvements, fixes, etc. (and currently I already see 2 > > >> addition > > >> > >> > > commits) > > >> > >> > > > the next step should be to adjust the license headers! > > >> > >> > > > > > >> > >> > > > > >> > >> > > So, here: > > >> > >> > > https://cwiki.apache.org/confluence/display/NETBEANS/ > > >> > >> > > NetBeans+Transition+Process#NetBeansTransitionProcess- > > >> > >> > > ChangingGPL+CDDLlicenseheaders > > >> > >> > > > > >> > >> > > I tried to prepare a regexp that matches most existing > > >> (normalized) > > >> > >> > license > > >> > >> > > headers. If someone could check if it is OK to change > matching > > >> > >> headers, I > > >> > >> > > think that would be great. (Please let me know if there are > any > > >> > >> > question.) > > >> > >> > > > > >> > >> > > Jan > > >> > >> > > > > >> > >> > > > > >> > >> > > > Which this should be done by a Oracle representing > committer, > > >> e.g. > > >> > >> like > > >> > >> > > > what > > >> > >> > > > Jaroslav did for the -html4j repository. > > >> > >> > > > > > >> > >> > > > Regards, > > >> > >> > > > Ate (who regrettably has very limited time this week to > > monitor > > >> > >> > anything > > >> > >> > > > going on here) > > >> > >> > > > > > >> > >> > > > > > >> > >> > > > On 2017-09-11 17:04, Geertjan Wielenga wrote: > > >> > >> > > > > > >> > >> > > >> Hi all, > > >> > >> > > >> > > >> > >> > > >> Big milestone -- > > >> > >> > > >> > > >> > >> > > >> git://git.apache.org/incubator-netbeans.git > > >> > >> > > >> > > >> > >> > > >> https://github.com/apache/incubator-netbeans > > >> > >> > > >> > > >> > >> > > >> The main repo from the 1st code donation has landed in > > Apache > > >> > Git, > > >> > >> > > >> mirrored > > >> > >> > > >> at Apache GitHub. > > >> > >> > > >> > > >> > >> > > >> Thanks all, especially Petr Gebauer, for doing the push, > and > > >> > thanks > > >> > >> > also > > >> > >> > > >> for the great support via Apache infra today. > > >> > >> > > >> > > >> > >> > > >> Gj > > >> > >> > > >> > > >> > >> > > >> > > >> > >> > > > > > >> > >> > > > > >> > >> > > > >> > >> > > >> > > > > >> > > > > >> > > > >> > > > > > > > > >
