Hi, I like the idea of an external GitHub that we can use to quickly fire in some of the troublesome modules into to get around the license issues like Camel did, and it seems there's already a GitHub Organisation lying there in wait for modules ;)
Just did a quick search for usages of "hibernate" in the repository, and got a couple of questions. 1. Alot of modules in the project.xml have a friend-packages element with: <friend>org.netbeans.modules.hibernate</friend> I assume even if this "friend" module doesn't exist in the IDE it shouldn't affect the module, correct? 2. The j2ee.persistence module has references to icons from the hibernate package, provided there Oracles images, and not Hibernate, I assume we could just move the icon and reference, no? private static final String HB_MAPPING_ICON = "org/netbeans/modules/hibernate/resources/hibernate-mapping.png"; //NOI18N A lot of the other references are references to hibernate in text, again from a quick search I don't fully know how or what their being used for, I assume unless someone with intimate knowledge of this area speaks up, we'll probably have to get down there and dig around... If I get time over the next few days / next week, I might see about removing references to the Hibernate modules locally and seeing what breaks in relation to the JPA / Persistence Units etc stuff in the UI. - maybe see if there are any 8.2 NetCat test specs for this to use as an acceptance test... Regards John On 21 November 2017 at 22:17, Jan Lahoda <lah...@gmail.com> wrote: > Hi Sven, > > Thanks for looking at this. For completeness, I think (but IANAL) we could > have code here that depends on Hibernate (or other GPL libraries), but it > a) needs to be an optional component; b) we cannot distribute the GPL > library from Apache: > https://www.apache.org/legal/resolved.html#optional > > if it makes more sense for the hibernate support to be distributed disabled > with the IDE (so the user would only install the library if desired) or > separately is a question, but I personally know almost nothing about it, so > I don't have an opinion on that. > > Jan > > > On Tue, Nov 21, 2017 at 10:45 PM, Sven Reimers <sven.reim...@gmail.com> > wrote: > >> Hi all, >> >> Jan just asked about a couple of problematic external libraries - one of >> them is hibernate. >> >> Looking at the rules I think we cannot distribute modules relying on >> Hibernate with Apache NetBeans. >> >> So I did a quick dive and found a major problem. At the moment there is a >> special support module for Hibernate (supporting stuff like HQL..). I think >> we have to get rid of that (still have to check for further modules >> depending on this module). This is the only module using "import >> org.hibernate.*" statements. >> >> Idea: Maybe we can move the Hibernate Support module over to another >> community place so the code does not get lost and we can try to release a >> plugin from there - how about that? Not sure what the correct process and >> correct licensing for this module would be.. >> >> I found this http://camel.apache.org/hibernate.html and >> https://github.com/camel-extra/camel-extra/tree/master/ >> components/camel-hibernate >> as an example of another Apache project not being able to use LGPL >> components at Apache. >> >> There is https://github.com/netbeans-community - some distant time in the >> past Florian and I thought this may be a good place to bundle community >> efforts around NetBeans - maybe we could use this now? >> >> Comments? >> >> -Sven >> >> P.S. I think if we get the JavaEE part this will be much harder - I assume >> some of the JPA magic will rely on use of Hibernate - we will have to >> switch this over to OpenJPA or EclipseLink (both should be good in terms of >> license - I think...) >>
