I've done a separate pull request for the new splash images for the release90 branch, since I'm using the web interface for doing these changes and I don't see a way to do cherry picking there:
https://github.com/apache/incubator-netbeans/pull/605 Gj On Tue, Jun 26, 2018 at 6:25 AM, Thilina Ranathunga <r.thil...@gmail.com> wrote: > Hi, > > Take a look at this pull request - Update updater splash #604 > > https://github.com/apache/incubator-netbeans/pull/604 > > On Tue, Jun 26, 2018 at 1:25 AM Lars Bruun-Hansen <lbruunhan...@gmail.com> > wrote: > > > This is all documented in NETBEANS-146. It lists all the artwork, > including > > that for the Updater Splash. It also lists the locations for both > Platform > > and IDE (just hover over the links). IDE overrides Platform. > > > > I wouldn't close NETBEANS-146 just yet, as long as not everything > mentioned > > is replaced, notably the Updater Splash. Besides this, you'll notice that > > there's even more outstanding artwork which is mentioned in the ticket, > but > > that belongs to the 2nd (or even later) code donation, so cannot be > changed > > at the moment. > > > > I've been offline for some time so haven't been following your excellent > > progress. > > > > -Lars > > > > > > On Mon, Jun 25, 2018 at 5:08 PM, Geertjan Wielenga < > > geertjan.wiele...@googlemail.com.invalid> wrote: > > > > > Here they are: > > > > > > core.startup/src/org/netbeans/core/startup/splash.gif > > > core.startup/src/org/netbeans/core/startup/splash_dark.gif > > > > > > Thanks, > > > > > > Gj > > > > > > > > > > > > > > > On Mon, Jun 25, 2018 at 5:04 PM, Geertjan Wielenga < > > > geertjan.wiele...@googlemail.com> wrote: > > > > > > > > > > > Here's the location of the updater image, I believe: > > > > > > > > ide.branding/autoupdate.services/libsrc/org/netbeans/ > updater/resources/ > > > > updatersplash_nb.gif > > > > > > > > The other one I haven't found yet, i.e., the one for the NetBeans > > > Platform > > > > application. > > > > > > > > Gj > > > > > > > > > > > > > > > > > > > > On Sun, Jun 24, 2018 at 11:36 PM, Laszlo Kishalmi < > > > > laszlo.kisha...@gmail.com> wrote: > > > > > > > >> And if we get a chance the branding when you create a new platform > > > >> application project is still the old branding. > > > >> > > > >> (https://issues.apache.org/jira/browse/NETBEANS-990) I could not > find > > > >> the code responsible for that at the first scan. > > > >> > > > >> > > > >> > > > >> > > > >> On 06/24/2018 12:16 PM, Geertjan Wielenga wrote: > > > >> > > > >>> Yes. > > > >>> > > > >>> Gj > > > >>> > > > >>> On Sun, Jun 24, 2018 at 8:56 PM, Sven Reimers < > > sven.reim...@gmail.com> > > > >>> wrote: > > > >>> > > > >>> So we still need to update the updater as well for NetBeans 9.0 > > > release? > > > >>>> > > > >>>> -Sven > > > >>>> > > > >>>> Geertjan Wielenga <geertjan.wiele...@googlemail.com.invalid> > > schrieb > > > am > > > >>>> So., 24. Juni 2018, 19:25: > > > >>>> > > > >>>> I don't believe the update dialog has been updated -- I only > updated > > > the > > > >>>>> splash screen and the About box. > > > >>>>> > > > >>>>> Those new images are in 'ide.branding'. > > > >>>>> > > > >>>>> Gj > > > >>>>> > > > >>>>> On Sun, Jun 24, 2018 at 6:36 PM, Sven Reimers < > > > sven.reim...@gmail.com> > > > >>>>> wrote: > > > >>>>> > > > >>>>> Hi all, > > > >>>>>> > > > >>>>>> can anyone confirm that the branding of the update dialog has > been > > > >>>>>> > > > >>>>> updated? > > > >>>>> > > > >>>>>> I just tried with a local build of the latest 90release branch > and > > > saw > > > >>>>>> > > > >>>>> the > > > >>>>> > > > >>>>>> old blue updater splash (this is on mac os). > > > >>>>>> > > > >>>>>> Just trying to figure out if this is just me seeing this.. > > > >>>>>> > > > >>>>>> Thanks > > > >>>>>> > > > >>>>>> -Sven > > > >>>>>> > > > >>>>>> -- > > > >>>>>> Sven Reimers > > > >>>>>> > > > >>>>>> * Senior Expert Software Architect > > > >>>>>> * Java Champion > > > >>>>>> * NetBeans Dream Team Member: http://dreamteam.netbeans.org > > > >>>>>> * JUG Leader JUG Bodensee: http://www.jug-bodensee.de > > > >>>>>> * Duke's Choice Award Winner 2009 > > > >>>>>> > > > >>>>>> > > > >> > > > >> ------------------------------------------------------------ > --------- > > > >> To unsubscribe, e-mail: dev-unsubscribe@netbeans. > incubator.apache.org > > > >> For additional commands, e-mail: > > dev-h...@netbeans.incubator.apache.org > > > >> > > > >> For further information about the NetBeans mailing lists, visit: > > > >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >> > > > >> > > > >> > > > >> > > > > > > > > > > > > -- > > Best regards, > Thilina Ranathunga. >
