Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/246#discussion_r54328675
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
---
@@ -177,10 +179,19 @@
.addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
.build();
+ public static final PropertyDescriptor SERVER_SIDE_ENCRYPTION = new
PropertyDescriptor.Builder()
+ .name("Server Side Encryption")
--- End diff --
I totally understand consistency over convention. If I'm being selfish, I'd
say it is better to do it correctly *and* correct the other existing settings.
The preferred and prescribed form is to use `.name()` for the unique value. See
`EncryptContent` processor for a more complete example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
