Github user alopresto commented on the pull request:

    https://github.com/apache/nifi/pull/246#issuecomment-190467028
  
    @adamonduty that looks good. I understand the confusion around this 
undocumented convention. 
    
    My only outstanding request would be to combine the two commits into a 
single commit (via `rebase --interactive` and `push --force`) to condense the 
PR and then one of the committers should be able to merge it. Feel free to 
include my linked simple validation tests as well. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to