Github user olegz commented on the pull request:

    https://github.com/apache/nifi/pull/453#issuecomment-220173989
  
    @mosermw I think as a community we should stay away from jumping to quick 
conclusions without giving this PR a thorough and adequate review as we do with 
others.
    SFTP and SCP are two different protocols and while they both utilize the 
same SSH encryption during file transfer, there are quite a few differences 
which I am sure you can read up on, with performance being one of them (SCP 
being faster) etc.
    As for JSch as a library, it is neither SFTP nor SCP. It is simple Java 
implementation of SSH2, allowing anyone to build components that need to 
interact over SSH. So _"processors here are still using SFTP under the covers"_ 
is not really accurate? What I think is more accurate is that both processors 
utilize the same library (JSch) to accomplish the set goal.  
    Now, I am not saying there are no issues with @eorgad's  code, 
configuration, documentation etc. I have not personally had a chance to look 
through it yet, and I am sure there are things that may be incorrect or things 
that could be improved. So in the spirit of community and collaboration let's 
concentrate on those. There will be plenty of time in the end to cast up/down 
votes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to