Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/501
  
    @YolandaMDavis I left several comments inline. Only other comment that I 
have is that it feels a little weird to me to have `ControllerServiceLookup` 
extend `VariableRegistryProvider`. These are really unrelated concepts... any 
insight as to why you went that route?
    
    Otherwise, all is looking great! Certainly not a trivial addition to the 
codebase. Thanks for sticking with it to get all of this knocked out!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to