Github user YolandaMDavis commented on a diff in the pull request: https://github.com/apache/nifi/pull/501#discussion_r67282864 --- Diff: nifi-api/src/main/java/org/apache/nifi/registry/FileVariableRegistry.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.registry; + +import java.io.File; +import java.io.IOException; +import java.nio.file.Path; +import java.util.Map; + + +public abstract class FileVariableRegistry extends MultiMapVariableRegistry { + + public FileVariableRegistry() { + super(); + } + + public FileVariableRegistry(File... files){ + super(); + addVariables(files); + } + + public FileVariableRegistry(Path... paths){ + super(); + addVariables(paths); + } + + @SuppressWarnings({"unchecked", "rawtypes"}) + public void addVariables(File ...files){ + if(files != null) { + for (final File file : files) { + try { + registry.addMap(convertFile(file)); + } catch (IOException iex) { + throw new IllegalArgumentException("A file provided was invalid.", iex); + } + } + } + } + + @SuppressWarnings({"unchecked", "rawtypes"}) + public void addVariables(Path ...paths){ + if(paths != null) { + for (final Path path : paths) { + try { + registry.addMap(convertFile(path.toFile())); + } catch (IOException iex) { + throw new IllegalArgumentException("A path provided was invalid.", iex); + } + } + } + } + + protected abstract Map convertFile(File file) throws IOException; --- End diff -- sorry I missed this line @markap14 in the updates. Thought about making this Map<String,String> however that would mean in PropertiesVariableRegistry converting Properties to that format (which I think requires me to create and populate a new map, not just cast). I can do that was just trying to reduce cost of conversion.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---