+1 (non-binding) Verified source package per release helper. Built on Ubuntu 14.04, all unit tests and contrib-check pass. Built on Windows 10, some unit tests fail and contrib-check fails on "nifi-poi-processors: Too many files with unapproved license" but I think this was expected. The build without contrib-check and using -DskipTests works. Ran some simple flows that worked as expected.
Many thanks to the community for all of the work put into this release! And thanks to Jeff for being RM. On Fri, Sep 29, 2017 at 4:44 PM, Scott Aslan <scottyas...@gmail.com> wrote: > +1 (non-binding) Release this package as nifi-1.4.0 > > On Fri, Sep 29, 2017 at 11:52 AM, Mark Payne <marka...@hotmail.com> wrote: > >> +1 (binding) >> >> Verified hashes and checksum. Built with all unit tests and contrib-check >> on OSX. >> >> Was able to startup and test simple flows worked as expected. >> >> > On Sep 29, 2017, at 11:20 AM, Marc P. <marc.par...@gmail.com> wrote: >> > >> > +1 non-binding >> > >> > -- verified contrib-check >> > -- ran simple flows with MiNiFi >> > -- sigs and hashes look good. >> > >> > Thanks for sending this out Jeff! >> > >> > >> > On Fri, Sep 29, 2017 at 11:18 AM, Matt Gilman <matt.c.gil...@gmail.com> >> > wrote: >> > >> >> +1 (binding) Release this package as nifi-1.4.0 >> >> >> >> On Fri, Sep 29, 2017 at 11:07 AM, Bryan Bende <bbe...@gmail.com> wrote: >> >> >> >>> +1 (binding) >> >>> >> >>> - Ran through the release helper and everything checked out. >> >>> - Ran a couple of sample flows with no issues >> >>> >> >>> >> >>> On Fri, Sep 29, 2017 at 9:46 AM, James Wing <jvw...@gmail.com> wrote: >> >>>> Jeff, I agree the updated KEYS file has been published. Thanks. >> >>>> >> >>>> On Fri, Sep 29, 2017 at 6:00 AM, Jeff <jtsw...@gmail.com> wrote: >> >>>> >> >>>>> James, >> >>>>> >> >>>>> I had to do a hard reload of the page in Chrome, since the browser >> >> kept >> >>>>> showing me a cached version without my key. After the hard reload, I >> >>> can >> >>>>> see my key at https://dist.apache.org/repos/dist/dev/nifi/KEYS. >> >> Could >> >>> you >> >>>>> try opening the KEYS link in incognito mode and verify that my key is >> >>>>> there? >> >>>>> >> >>>>> Thanks, >> >>>>> Jeff >> >>>>> >> >>>>> On Fri, Sep 29, 2017 at 1:06 AM James Wing <jvw...@gmail.com> wrote: >> >>>>> >> >>>>>> +1 (binding). I ran through the release helper including signature, >> >>>>> hashes, >> >>>>>> build, and testing the binary. I checked the LICENSE and NOTICE >> >>> files. >> >>>>>> Everything looks good to me. >> >>>>>> >> >>>>>> One thing I noted is that Jeff's GPG key is not yet in the public >> >> KEYS >> >>>>> file >> >>>>>> at https://dist.apache.org/repos/dist/dev/nifi/KEYS, but it is >> >> added >> >>> in >> >>>>>> the >> >>>>>> master branch KEYS file to be published with the release. I believe >> >>> that >> >>>>>> is OK for the signature, we've done this before, and perhaps we >> >> should >> >>>>>> consider changing the helper text in the future. >> >>>>>> >> >>>>>> Thanks, Jeff, for putting this release together. >> >>>>>> >> >>>>>> >> >>>>>> On Thu, Sep 28, 2017 at 12:54 PM, Jeff <jsto...@apache.org> wrote: >> >>>>>> >> >>>>>>> Hello, >> >>>>>>> >> >>>>>>> I am pleased to be calling this vote for the source release of >> >>> Apache >> >>>>>> NiFi >> >>>>>>> nifi-1.4.0. >> >>>>>>> >> >>>>>>> The source zip, including signatures, digests, etc. can be found >> >> at: >> >>>>>>> https://repository.apache.org/content/repositories/ >> >>> orgapachenifi-1111 >> >>>>>>> >> >>>>>>> The Git tag is nifi-1.4.0-RC2 >> >>>>>>> The Git commit ID is e6508ba7d3da5bba54abd6233a7a8f9dd4c32151 >> >>>>>>> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h= >> >>>>>>> e6508ba7d3da5bba54abd6233a7a8f9dd4c32151 >> >>>>>>> >> >>>>>>> Checksums of nifi-1.4.0-source-release.zip: >> >>>>>>> MD5: 41e4083e602883a3e180032f32913414 >> >>>>>>> SHA1: 26770625138126f45bed4989adb0a6b65a767aa2 >> >>>>>>> >> >>>>>>> Release artifacts are signed with the following key: >> >>>>>>> https://people.apache.org/keys/committer/jstorck.asc >> >>>>>>> >> >>>>>>> KEYS file available here: >> >>>>>>> https://dist.apache.org/repos/dist/release/nifi/KEYS >> >>>>>>> >> >>>>>>> 199 issues were closed/resolved for this release: >> >>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> >>>>>>> projectId=12316020&version=12340589 >> >>>>>>> >> >>>>>>> Release note highlights can be found here: >> >>>>>>> https://cwiki.apache.org/confluence/display/NIFI/ >> >>>>>>> Release+Notes#ReleaseNotes-Version-1.4.0 >> >>>>>>> >> >>>>>>> The vote will be open for 72 hours. >> >>>>>>> Please download the release candidate and evaluate the necessary >> >>> items >> >>>>>>> including checking hashes, signatures, build >> >>>>>>> from source, and test. The please vote: >> >>>>>>> >> >>>>>>> [ ] +1 Release this package as nifi-1.4.0 >> >>>>>>> [ ] +0 no opinion >> >>>>>>> [ ] -1 Do not release this package because... >> >>>>>>> >> >>>>>> >> >>>>> >> >>> >> >> >> >>
