Hello We'd need to see the output showing the actual test failures. Probably good to file a JIRA for resolution of it as well.
I see no issues on Java 8 or 11 on OSX or Linux or Travis. Thanks On Wed, Oct 23, 2019 at 2:34 PM José Maria Vieira <zevieir...@gmail.com> wrote: > Hi Joe, > > I followed your guide and tried building, but it failed the proccess. > Seems nifi-poi-processors is failing some tests. > > I got the following error: > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 10:15 min (Wall Clock) > [INFO] Finished at: 2019-10-23T17:45:06+01:00 > [INFO] > ------------------------------------------------------------------------ > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) > on project nifi-poi-processors: There are test failures. > [ERROR] > [ERROR] Please refer to > /home/jose/nifi-1.10.0/nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/target/surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, > [date].dumpstream and [date]-jvmRun[N].dumpstream. > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, > please read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > [ERROR] > [ERROR] After correcting the problems, you can resume the build with the > command > [ERROR] mvn <goals> -rf :nifi-poi-processors > Destroying 1 processes > Destroying process.. > Destroyed 1 processes > > > > > On 2019/10/22 12:21:49, Joe Witt <joe.w...@gmail.com> wrote: > > Team, > > > > I've initiated the 1.10.0 RC1 process. Hopefully will have the bits/vote > up > > for review today. > > > > Thanks > > Joe > > > > On Wed, Oct 16, 2019 at 9:52 AM Mike Thomsen <mikerthom...@gmail.com> > wrote: > > > > > Before we go to RC, has anyone tested at least > PutElasticsearchHttpRecord > > > against Elastic 7.X? I know there were API changes that might need to > be > > > accounted for when 7.X was created. If no one's tried that out, I can > try > > > to find some time to do some testing. > > > > > > On Tue, Oct 15, 2019 at 1:36 PM Joe Witt <joe.w...@gmail.com> wrote: > > > > > > > rgr mark - that one is easy - i'll take care of it shortly > > > > > > > > > > > > On Tue, Oct 15, 2019 at 12:51 PM Mark Bean <mark.o.b...@gmail.com> > > > wrote: > > > > > > > > > Trivial pull request waiting on review; would be nice to get in > 1.10.0. > > > > > > > > > > https://github.com/apache/nifi/pull/3810 > > > > > > > > > > Thanks. > > > > > > > > > > On Tue, Oct 15, 2019 at 10:58 AM Joe Witt <joe.w...@gmail.com> > wrote: > > > > > > > > > > > Thanks team. Progressing RC for 1.10.0 tasks now. > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Oct 3, 2019 at 12:55 PM Bryan Bende <bbe...@gmail.com> > > > wrote: > > > > > > > > > > > > > Done! > > > > > > > > > > > > > > On Thu, Oct 3, 2019 at 12:37 PM Mike Thomsen < > > > mikerthom...@gmail.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > Could we get this small PR merged (reviews appear to be > done)? > > > > > > > > > > > > > > > > https://github.com/apache/nifi/pull/3723 > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > Mike > > > > > > > > > > > > > > > > On Thu, Oct 3, 2019 at 5:55 AM koter...@yahoo-corp.jp < > > > > > > > > koter...@yahoo-corp.jp> wrote: > > > > > > > > > > > > > > > > > Hi Pierre, > > > > > > > > > Thanks for your quick reviews! > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > Kotaro Terada > > > > > > > > > > > > > > > > > > ________________________________ > > > > > > > > > 差出人: Pierre Villard <pierre.villard...@gmail.com> > > > > > > > > > 送信日時: Thursday, October 3, 2019 6:40:29 PM > > > > > > > > > 宛先: dev@nifi.apache.org <dev@nifi.apache.org> > > > > > > > > > 件名: Re: [discuss] approaching a NiFi 1.10.0 release > > > > > > > > > > > > > > > > > > Thanks Koji, I went ahead and squashed/merged the PR into > > > master, > > > > > > > thanks! > > > > > > > > > Kotaro, I took care of your two PRs, thanks for fixing the > > > > issues! > > > > > > > > > > > > > > > > > > Pierre > > > > > > > > > > > > > > > > > > Le jeu. 3 oct. 2019 à 10:44, koter...@yahoo-corp.jp < > > > > > > > > > koter...@yahoo-corp.jp> > > > > > > > > > a écrit : > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > I found some bugs in PrometheusReportingTask (which is > newly > > > > > > > introduced > > > > > > > > > in > > > > > > > > > > 1.10) and I already sent PRs for fixing them (NIFI-6716< > > > > > > > > > > https://issues.apache.org/jira/browse/NIFI-6716> and > > > > NIFI-6715< > > > > > > > > > > https://issues.apache.org/jira/browse/NIFI-6715>). > > > > > > > > > > > > > > > > > > > > Could someone take a look into them, please? I think it's > > > > better > > > > > to > > > > > > > > > handle > > > > > > > > > > them before the 1.10 release, if possible. > > > > > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > Kotaro Terada > > > > > > > > > > > > > > > > > > > > ________________________________ > > > > > > > > > > 差出人: Koji Kawamura <ijokaruma...@gmail.com> > > > > > > > > > > 送信日時: 2019年10月3日 9:04 > > > > > > > > > > 宛先: dev <dev@nifi.apache.org> > > > > > > > > > > 件名: Re: [discuss] approaching a NiFi 1.10.0 release > > > > > > > > > > > > > > > > > > > > Hi Pierre, > > > > > > > > > > > > > > > > > > > > The PR3394 looks good, but is hard to merge to master > without > > > > > > > manually > > > > > > > > > > resolving conflict, at least with the commands I know. > Please > > > > see > > > > > > my > > > > > > > > > > comment on the PR. > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > Koji > > > > > > > > > > > > > > > > > > > > On Thu, Oct 3, 2019 at 1:59 AM Pierre Villard > > > > > > > > > > <pierre.villard...@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > > > Someone willing to merge > > > > > > https://github.com/apache/nifi/pull/3394? > > > > > > > > > It's > > > > > > > > > > > been reviewed, just wanted to avoid merging my own PR. > > > > > > > > > > > > > > > > > > > > > > Le mer. 2 oct. 2019 à 18:44, Jeff <jtsw...@gmail.com> > a > > > > écrit > > > > > : > > > > > > > > > > > > > > > > > > > > > > > Joe, > > > > > > > > > > > > > > > > > > > > > > > > NIFI-6275 [1] has been resolved, and PR 3483 [2] has > been > > > > > > merged > > > > > > > to > > > > > > > > > > master. > > > > > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/NIFI-6275 > > > > > > > > > > > > [2] https://github.com/apache/nifi/pull/3483 > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Oct 1, 2019 at 12:30 AM Jeff < > jtsw...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > Thanks Joe! I should have an update/resolution for > > > > > NIFI-6275 > > > > > > > > > > tomorrow. > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Sep 30, 2019 at 11:48 PM Joe Witt < > > > > > > joe.w...@gmail.com> > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > >> Team, > > > > > > > > > > > > >> > > > > > > > > > > > > >> We are pretty much there now it looks like for a > > > 1.10.0. > > > > > In > > > > > > > > > > scanning > > > > > > > > > > > > >> through this thread it looks like the ListHDFS ask > > > from > > > > > Jeff > > > > > > > is > > > > > > > > > > perhaps > > > > > > > > > > > > >> the > > > > > > > > > > > > >> only remaining bit. > > > > > > > > > > > > >> > > > > > > > > > > > > >> I'll probably create the RC branch soon so folks > can > > > > keep > > > > > > > moving > > > > > > > > > on > > > > > > > > > > > > master > > > > > > > > > > > > >> and I'll try to pull in other things that look > > > > > > > > > ready/reviewed/etc.. > > > > > > > > > > that > > > > > > > > > > > > >> might work. > > > > > > > > > > > > >> > > > > > > > > > > > > >> If you look here > > > > > > > > > > > > >> > > > > > > > https://issues.apache.org/jira/projects/NIFI/versions/12344993 > we > > > > > > > > > > > > already > > > > > > > > > > > > >> have a *TON* of features/fixes/improvements > loaded up > > > on > > > > > > this > > > > > > > > > > release. > > > > > > > > > > > > >> > > > > > > > > > > > > >> My goal is to initiate the RC processes this week. > > > > > > > > > > > > >> > > > > > > > > > > > > >> Huge thanks to the many many folks that > contributed to > > > > > > > getting us > > > > > > > > > > this > > > > > > > > > > > > far > > > > > > > > > > > > >> in this release. > > > > > > > > > > > > >> > > > > > > > > > > > > >> Thanks! > > > > > > > > > > > > >> Joe > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > >> On Fri, Aug 30, 2019 at 4:21 AM Pierre Villard < > > > > > > > > > > > > >> pierre.villard...@gmail.com> > > > > > > > > > > > > >> wrote: > > > > > > > > > > > > >> > > > > > > > > > > > > >> > +1 for getting a 1.10.0 release soon - a lot of > > > great > > > > > > > things has > > > > > > > > > > been > > > > > > > > > > > > >> > added. > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > If I may ask, it would be great to have a +1 > from a > > > > > > > committer on > > > > > > > > > > > > >> NIFI-6159 > > > > > > > > > > > > >> > [1]. > > > > > > > > > > > > >> > The PR has been reviewed by turcsanyip but it > would > > > > > need a > > > > > > > final > > > > > > > > > > go > > > > > > > > > > > > >> from a > > > > > > > > > > > > >> > committer. > > > > > > > > > > > > >> > However, I do understand that other PRs > mentioned in > > > > > this > > > > > > > thread > > > > > > > > > > are > > > > > > > > > > > > >> more > > > > > > > > > > > > >> > important (bug related). > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > [1] https://github.com/apache/nifi/pull/3394 > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > Thanks, > > > > > > > > > > > > >> > Pierre > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > Le ven. 30 août 2019 à 08:21, Jeff < > > > jtsw...@gmail.com > > > > > > > > > > a > > > > > > > écrit > > > > > > > > > : > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > I'd also like to get the PR [1] for NIFI-6275 > > > merged > > > > > > > before > > > > > > > > > > 1.10.0 > > > > > > > > > > > > is > > > > > > > > > > > > >> > > released. It's an update to ListHDFS so that > the > > > > > scheme > > > > > > > and > > > > > > > > > > > > authority > > > > > > > > > > > > >> > are > > > > > > > > > > > > >> > > ignored when using the "Full Path" filter > mode. > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > [1] https://github.com/apache/nifi/pull/3483 > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > On Thu, Aug 29, 2019 at 10:04 PM Aldrin Piri < > > > > > > > > > > aldrinp...@gmail.com> > > > > > > > > > > > > >> > wrote: > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > I created NIFI-6604 [1] to reduce assembly > size > > > > and > > > > > > > listed > > > > > > > > > it > > > > > > > > > > as a > > > > > > > > > > > > >> > > Blocker > > > > > > > > > > > > >> > > > for this release. The issue has a link to > the > > > > > > > associated > > > > > > > > > > > > discussion > > > > > > > > > > > > >> > > thread > > > > > > > > > > > > >> > > > and an initial PR. > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > --aldrin > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > [1] > > > > https://issues.apache.org/jira/browse/NIFI-6604 > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > On Thu, Aug 29, 2019 at 4:08 PM Matt > Burgess < > > > > > > > > > > mattyb...@gmail.com > > > > > > > > > > > > > > > > > > > > > > > > > >> > > wrote: > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > Mike, > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > I’ll review those two graph PRs tonight or > > > > > tomorrow > > > > > > > (if > > > > > > > > > > they’re > > > > > > > > > > > > >> still > > > > > > > > > > > > >> > > > open > > > > > > > > > > > > >> > > > > by then) > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > On Aug 29, 2019, at 3:43 PM, Mike > Thomsen < > > > > > > > > > > > > >> mikerthom...@gmail.com> > > > > > > > > > > > > >> > > > > wrote: > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > I have two open graph-related PR's that > are > > > > > really > > > > > > > small > > > > > > > > > > and > > > > > > > > > > > > are > > > > > > > > > > > > >> > > needed > > > > > > > > > > > > >> > > > > to > > > > > > > > > > > > >> > > > > > close some bugs that will be bad for > early > > > > > > adopters: > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > https://github.com/apache/nifi/pull/3571 > > > > > > > > > > > > >> > > > > > > https://github.com/apache/nifi/pull/3572 > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > If someone wants to review, that'd be > great. > > > > > > > Otherwise, > > > > > > > > > I > > > > > > > > > > can > > > > > > > > > > > > >> merge > > > > > > > > > > > > >> > > > them > > > > > > > > > > > > >> > > > > in > > > > > > > > > > > > >> > > > > > because I'm doing daily work on some > graph > > > > stuff > > > > > > > using a > > > > > > > > > > > > branch > > > > > > > > > > > > >> > based > > > > > > > > > > > > >> > > > on > > > > > > > > > > > > >> > > > > > both patches. > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > Thanks, > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > Mike > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > >> On Thu, Aug 29, 2019 at 2:12 PM Joe > Witt < > > > > > > > > > > joe.w...@gmail.com > > > > > > > > > > > > > > > > > > > > > > > > > >> > > wrote: > > > > > > > > > > > > >> > > > > >> > > > > > > > > > > > > >> > > > > >> We had another discuss on that > recently and > > > > the > > > > > > > intent > > > > > > > > > > is to > > > > > > > > > > > > >> drop > > > > > > > > > > > > >> > a > > > > > > > > > > > > >> > > > few > > > > > > > > > > > > >> > > > > >> toys off the raft and update migration > > > > > guidance. > > > > > > > > > > > > >> > > > > >> > > > > > > > > > > > > >> > > > > >> Thanks > > > > > > > > > > > > >> > > > > >> > > > > > > > > > > > > >> > > > > >>> On Thu, Aug 29, 2019 at 2:02 PM Jeremy > > > Dyer > > > > < > > > > > > > > > > > > jdy...@gmail.com > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > wrote: > > > > > > > > > > > > >> > > > > >>> > > > > > > > > > > > > >> > > > > >>> +1 looking forward to this. > > > > > > > > > > > > >> > > > > >>> > > > > > > > > > > > > >> > > > > >>> I recall seeing some issues about > Apache > > > > Infra > > > > > > > and the > > > > > > > > > > > > binary > > > > > > > > > > > > >> > size. > > > > > > > > > > > > >> > > > > Were > > > > > > > > > > > > >> > > > > >>> all of those appropriate modules > removed > > > as > > > > > > > discussed > > > > > > > > > > and > > > > > > > > > > > > the > > > > > > > > > > > > >> > build > > > > > > > > > > > > >> > > > > size > > > > > > > > > > > > >> > > > > >>> will be small enough now? > > > > > > > > > > > > >> > > > > >>> > > > > > > > > > > > > >> > > > > >>>> On Thu, Aug 29, 2019 at 1:35 PM Bryan > > > > Bende < > > > > > > > > > > > > >> bbe...@gmail.com> > > > > > > > > > > > > >> > > > wrote: > > > > > > > > > > > > >> > > > > >>>> > > > > > > > > > > > > >> > > > > >>>> +1 Looking forward to getting > parameters > > > > and > > > > > > > Java 11 > > > > > > > > > > > > support > > > > > > > > > > > > >> out > > > > > > > > > > > > >> > > > there > > > > > > > > > > > > >> > > > > >>>> in a release. > > > > > > > > > > > > >> > > > > >>>> > > > > > > > > > > > > >> > > > > >>>>> On Thu, Aug 29, 2019 at 1:02 PM Joe > > > Witt < > > > > > > > > > > > > >> joew...@apache.org> > > > > > > > > > > > > >> > > > wrote: > > > > > > > > > > > > >> > > > > >>>>> > > > > > > > > > > > > >> > > > > >>>>> Team, > > > > > > > > > > > > >> > > > > >>>>> > > > > > > > > > > > > >> > > > > >>>>> It looks like we're reaching a > point in > > > > > which > > > > > > > it is > > > > > > > > > > time > > > > > > > > > > > > to > > > > > > > > > > > > >> > close > > > > > > > > > > > > >> > > > in > > > > > > > > > > > > >> > > > > >> on > > > > > > > > > > > > >> > > > > >>>>> 1.10. > > > > > > > > > > > > >> > > > > >>>>> > > > > > > > > > > > > >> > > > > >>>>> > > > > > > > > > > > > >> > > > > >>>> > > > > > > > > > > > > >> > > > > >>> > > > > > > > > > > > > >> > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/NIFI-6595?jql=project%20%3D%20NIFI%20AND%20fixVersion%20%3D%201.10.0 > > > > > > > > > > > > >> > > > > >>>>> > > > > > > > > > > > > >> > > > > >>>>> There are 250+ issues in there > nearly > > > 240 > > > > of > > > > > > > which > > > > > > > > > are > > > > > > > > > > > > >> already > > > > > > > > > > > > >> > > > > >>>> resolved. I > > > > > > > > > > > > >> > > > > >>>>> haven't gone through yet for fully > > > > analyzing > > > > > > > but the > > > > > > > > > > > > awesome > > > > > > > > > > > > >> > Java > > > > > > > > > > > > >> > > > 11 > > > > > > > > > > > > >> > > > > >>> work > > > > > > > > > > > > >> > > > > >>>>> Jeff Storck and others has done > means we > > > > can > > > > > > now > > > > > > > > > > build on > > > > > > > > > > > > >> Java > > > > > > > > > > > > >> > 11 > > > > > > > > > > > > >> > > > as > > > > > > > > > > > > >> > > > > >>> well > > > > > > > > > > > > >> > > > > >>>>> as run on it. There is a ton of > great > > > > work > > > > > on > > > > > > > > > > parameters > > > > > > > > > > > > >> which > > > > > > > > > > > > >> > > > will > > > > > > > > > > > > >> > > > > >>> make > > > > > > > > > > > > >> > > > > >>>>> managing flows at scale much > easier. We > > > > > will > > > > > > > need > > > > > > > > > to > > > > > > > > > > drop > > > > > > > > > > > > >> some > > > > > > > > > > > > >> > > > nars > > > > > > > > > > > > >> > > > > >>>> which > > > > > > > > > > > > >> > > > > >>>>> means we have some migration > guidance to > > > > > > update. > > > > > > > > > > > > >> > > > > >>>>> > > > > > > > > > > > > >> > > > > >>>>> I'd like to volunteer as RM but if > there > > > > are > > > > > > any > > > > > > > > > other > > > > > > > > > > > > >> takers > > > > > > > > > > > > >> > > > please > > > > > > > > > > > > >> > > > > >>> let > > > > > > > > > > > > >> > > > > >>>> me > > > > > > > > > > > > >> > > > > >>>>> know. > > > > > > > > > > > > >> > > > > >>>>> > > > > > > > > > > > > >> > > > > >>>>> As we close in on releases this > tends to > > > > > > create > > > > > > > a > > > > > > > > > lot > > > > > > > > > > of > > > > > > > > > > > > >> > urgency > > > > > > > > > > > > >> > > to > > > > > > > > > > > > >> > > > > >>>> quickly > > > > > > > > > > > > >> > > > > >>>>> try to get new things in. I will > try to > > > > > > manage > > > > > > > this > > > > > > > > > > well. > > > > > > > > > > > > >> As > > > > > > > > > > > > >> > > > always > > > > > > > > > > > > >> > > > > >>> we > > > > > > > > > > > > >> > > > > >>>>> can do another release. There is no > > > > > timeline > > > > > > > > > pushing > > > > > > > > > > us > > > > > > > > > > > > to > > > > > > > > > > > > >> > have > > > > > > > > > > > > >> > > > such > > > > > > > > > > > > >> > > > > >>>> gaps > > > > > > > > > > > > >> > > > > >>>>> between releases...we can always do > > > > another > > > > > > > feature > > > > > > > > > > > > release. > > > > > > > > > > > > >> > > That > > > > > > > > > > > > >> > > > > >>> said, > > > > > > > > > > > > >> > > > > >>>> PR > > > > > > > > > > > > >> > > > > >>>>> review bandwidth is at a super > premium. > > > > We > > > > > > > receive > > > > > > > > > a > > > > > > > > > > lot > > > > > > > > > > > > >> more > > > > > > > > > > > > >> > > PRs > > > > > > > > > > > > >> > > > > >> than > > > > > > > > > > > > >> > > > > >>>> we > > > > > > > > > > > > >> > > > > >>>>> do receive reviews. We'll have to > work > > > > this > > > > > > as > > > > > > > the > > > > > > > > > PR > > > > > > > > > > > > depth > > > > > > > > > > > > >> > > grows. > > > > > > > > > > > > >> > > > > >>>>> > > > > > > > > > > > > >> > > > > >>>>> Thanks > > > > > > > > > > > > >> > > > > >>>>> Joe > > > > > > > > > > > > >> > > > > >>>> > > > > > > > > > > > > >> > > > > >>> > > > > > > > > > > > > >> > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
