Phil, Yeah, that’s fine. We want to include the Jira number in the commit message, but you can include multiple by writing a message like:
NIFI-3470, NIFI-1517: Addressed Thing #1 and Thing #2 Thanks -Mark > On Apr 4, 2022, at 10:27 AM, Phil H <gippyp...@gmail.com> wrote: > > Whilst I try and get NiFi to build, let's circle back to JIRA. I found an > open issue that matches my requirement (NIFI-1517), however to implement my > solution, I'd also fix NIFI-3470 on the way (reading a configurable amount > of data to run the regex over, rather than byte-by-byte). > > So, what's the proper way to go about this from a JIRA perspective? I > assume my branch would be nifi-1517 as that's the feature I'm building, but > it would also "solve" 3470? > > TIA, > Phil > > > > > On Thu, Mar 17, 2022 at 9:12 AM Joe Witt <joe.w...@gmail.com> wrote: > >> Phil >> >> I'd say if you have a good implementation in mind you should go for it. >> Sounds interesting. >> >> Thanks >> >> On Wed, Mar 16, 2022 at 3:59 PM Phil H <gippyp...@gmail.com> wrote: >> >>> Hi, >>> >>> This seems like an odd omission - aside from performance (presumably?) is >>> there a reason why there isn’t a regex option for the byte sequence? I >> need >>> one but thought I’d ask before I built my own. >>> >>> Thanks >>> Phil >>> >>