+1 binding. Sigs, hashes, L&N overall look good (very thorough on L&N!)
Need to fix the copyright year in NOTICE as it currently lists 2019. Thanks On Tue, May 24, 2022 at 12:04 PM Marc Parisi <phroc...@apache.org> wrote: > +1 > > verified sigs and hashes. > > Ran a simple flow, starting, stopping, and changing flow with c2 protocol. > > Everything looks good. Great stuff! > > Thanks, > Marc > > > > On Tue, May 24, 2022 at 9:56 AM Martin Zink <martinz...@apache.org> wrote: > > > Good idea, I've renamed the convenience binary > > > > On Tue, May 24, 2022 at 2:54 PM Marton Szasz <sza...@apache.org> wrote: > > > > > +1 (binding) > > > > > > Ran through the release helper guide. Tested the convenience binaries > > > with a RPG to the NiFi release candidate, then InvokeHTTP to another > > > MiNiFi C++ RC agent that I've built myself. > > > > > > I would rename the convenience binary package from > > > nifi-minifi-cpp-0.12.0-bin-centos.tar.gz to > > > nifi-minifi-cpp-0.12.0-bin-linux.tar.gz before finishing the release, > > > since it works on basically all major linux distros, even though it's > > > built on CentOS. We did the same with 0.11.0. > > > > > > Thanks! > > > > > > On Mon, 23 May 2022 at 13:28, Ferenc Gerlits <fgerl...@apache.org> > > wrote: > > > > > > > > +1 (non-binding) > > > > > > > > I have > > > > * verified the checksums and signatures > > > > * compared the contents of the source tarball to the > > > minifi-cpp-0.12.0-RC1 > > > > tag in git > > > > * ran the binary with a simple GenerateFlowFile -> LogAttribute flow, > > > with > > > > heartbeat logging on > > > > * connected to C2 > > > > > > > > Everything worked correctly. > > > > > > > > Thanks, > > > > Ferenc > > > > > >
