+1 (non-binding)
Verified hashes and signature on the source tarball, checked git
commit hash and tag.
Built on Windows 10 with 64-bit VS 2019, installed the msi package and
ran a simple CWEL -> LogAttribute flow.
I ran into some issues during the build, but none of them are showstoppers:
- the release helper guide should make it clear that win_build_vs.bat
defaults to 32-bit and you have to
add /64 to the command line if you want a 64-bit build (should we
make 64-bit the default?);
- win_build_vs.bat fails if the build directory path contains spaces;
- the cpack command in win_build_vs.bat found chocolatey on my
computer instead of CMake's cpack;
- the installer does not start the service (I don't know if it used
to, but I think it should).
Thank you,
Ferenc
