+1 (binding) Build on u20, tested a couple of simple flows.
Thanks! Le jeu. 31 août 2023 à 19:35, Arpad Boda <[email protected]> a écrit : > +1 (binding) > > Verified signature, hashes. > Built on debian and mac. > > Executed all tests successfully, verified c2 functionality, designed > multiple flows, verified those. > > Thanks, > Arpad > > > On Wed, Aug 30, 2023 at 7:11 PM Gábor Gyimesi <[email protected]> wrote: > > > +1 (non-binding) > > > > Went through the verification process using the helper guide. > > > > Compiled all but the JNI extension successfully on Ubuntu 22.04 with > > GCC 11, ran all unit and integration tests, did not find any issues. > > > > Compiled on Windows using MSVC and Ninja using Visual Studio 2019. > > Used the following command: win_build_vs.bat build /NINJA /P /K /S /A > > /SFTP /PDH /SPLUNK /GCP /ELASTIC /Z /PR /ENCRYPT_CONFIG /MQTT /OPC > > /PYTHON_SCRIPTING > > I had a compilation issue on Windows with the SFTP extension: linking > > SFTPLoader.cpp.obj failed with unresolved Curl symbols. Seems to be an > > issue of the static linkage of Curl, which is worth investigating, but > > I don't think it's a blocking issue. After removing SFTP from the > > compilation list the project compiled successfully. > > > > Ran two flows on both Windows (using the compiled binaries) and Linux > > (using the provided convenience binaries) successfully: > > TailFile -> LogAttribute > > GenerateFlowFile -> UpdateAttribute -> MergeContent -> CompressContent > > -> PutS3Object > > > > Note: Updated the > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=139627733 > > wiki page with the new OpenSSL build requirements on Windows. > > > > Thanks, > > Gábor > > > > On Tue, 29 Aug 2023 at 23:05, Marton Szasz <[email protected]> wrote: > > > > > > +1 (binding) > > > > > > Verified everything according to the release helper guide. > > > > > > On linux, bootstrap.sh installs all the required dependencies for > > > compiling with GCC. > > > - Ubuntu 22.04 / GCC: works fine > > > Clang required additional packages: clang libc++-dev libc++abi-dev > > > - Ubuntu 22.04 / Clang + libc++: didn't compile, but this is not a > > > showstopper IMO. We can fix it later and prepare the next release a > > > bit sooner. > > > - Ubuntu 22.04 / Clang + libstdc++: works fine > > > > > > Arch Linux / any compiler: linker issues related to curl. I wouldn't > > > tank the release for this. > > > > > > Windows steps: > > > 1. Used Visual Studio Community 2019 (VS2022 support is under review, > > > not yet included) > > > 2. Installed scoop (in powershell):> irm get.scoop.sh | iex > > > 3. Installed the latest cmake (for build), python (for scripting > > > support), sccache (for build caching, like ccache) and wixtoolset (for > > > installer generation) with scoop:> scoop install cmake python sccache > > > wixtoolset > > > 4. Source checked out at C:\a\m (to avoid long path issues) > > > 5. Built in "x64 Native Tools Command Prompt for VS2019" with the > > > following command:> win_build_vs.bat ..\bld /64 /P /K /S /A /SFTP /PDH > > > /SPLUNK /GCP /ELASTIC /Z /PR /ENCRYPT_CONFIG /MQTT /OPC > > > /PYTHON_SCRIPTING /D /NONFREEUCRT /SCCACHE > > > 6. Installed the resulting MSI, and copied cwel_config.yml from the > > > repo, but modified it to send the logs with PutTCP and PutUDP (2 > > > separate tests) to a netcat listening on a linux box. It worked well, > > > the logs arrived right away on the other box. Also tried the new saved > > > log file support. > > > > > > My reaction to Ferenc's issues: > > > - I agree that we should make 64bit the default in the future. > > > - I also ran into the cpack issue in the past, but we have a note > > > about it in the README, which is good enough for now IMO. > > > - I prefer not starting the service right after installation, before I > > > even have the chance to add my flow to config.yml, but C2 users may > > > have different preferences. > > > > > > Thanks, > > > Márton > > > > > > > > > > > > > > > > > > > > > On Tue, Aug 29, 2023 at 3:20 PM Ferenc Gerlits <[email protected]> > > wrote: > > > > > > > > +1 (non-binding) > > > > > > > > Verified hashes and signature on the source tarball, checked git > > > > commit hash and tag. > > > > Built on Windows 10 with 64-bit VS 2019, installed the msi package > and > > > > ran a simple CWEL -> LogAttribute flow. > > > > > > > > I ran into some issues during the build, but none of them are > > showstoppers: > > > > - the release helper guide should make it clear that > win_build_vs.bat > > > > defaults to 32-bit and you have to > > > > add /64 to the command line if you want a 64-bit build (should > we > > > > make 64-bit the default?); > > > > - win_build_vs.bat fails if the build directory path contains > spaces; > > > > - the cpack command in win_build_vs.bat found chocolatey on my > > > > computer instead of CMake's cpack; > > > > - the installer does not start the service (I don't know if it used > > > > to, but I think it should). > > > > > > > > Thank you, > > > > Ferenc > > >
