Pierre, Thanks for clarifying. I agree that going to Java 21 makes sense, and aligns with the NiFi main branch. That would be a breaking change, warranting the 2.0.0 version, so that sounds like a good plan.
Regards, David Handermann On Tue, May 21, 2024 at 10:32 AM Pierre Villard <pierre.villard...@gmail.com> wrote: > > My plan was to go with the latest for everything (including Java 21). > This way, NiFi NAR Maven plugin 2.0.0 would be used only for NiFi 2.x. > I actually think that the addition of the extension type "flow analysis > rules" would break things if used in the 1.x line (unless I also update the > enum in NiFi 1.x to include flow analysis rules as an extension type but > not sure that would be a great approach). > > Le mar. 21 mai 2024 à 17:24, David Handermann <exceptionfact...@apache.org> > a écrit : > > > Pierre, > > > > Thanks for highlighting the differences for Flow Analysis Rules. As > > far as making this a 2.0.0 release version, do you anticipate > > including any breaking changes? > > > > The current version of the plugin is built with Java 8, so this could > > be updated to Java 21, which would be a breaking change, however, that > > should be handled before the release process. > > > > If there are no breaking changes, I recommend a version 1.6.0 release > > before a 2.0.0 release of the plugin. > > > > Regards, > > David Handermann > > > > On Tue, May 21, 2024 at 10:19 AM Pierre Villard > > <pierre.villard...@gmail.com> wrote: > > > > > > Given that the flow analysis rules are something specific to NiFi 2, and > > > given that this is an opportunity to do some house cleaning, I'll go > > > directly to a 2.0.0 release directly and have it used only on the main > > > branch. The things that have been added as improvements are not really > > > required for 1.x anyway. > > > > > > Le mar. 21 mai 2024 à 15:40, David Handermann < > > exceptionfact...@apache.org> > > > a écrit : > > > > > > > Thanks Pierre, sounds good! > > > > > > > > Regards, > > > > David Handermann > > > > > > > > On Tue, May 21, 2024 at 8:36 AM Pierre Villard > > > > <pierre.villard...@gmail.com> wrote: > > > > > > > > > > Thanks will go ahead with 1.6.0 release process > > > > > > > > > > Le lun. 20 mai 2024 à 19:30, Matt Burgess <mattyb...@gmail.com> a > > écrit > > > > : > > > > > > > > > > > +1 for a 1.6.0 release > > > > > > > > > > > > On Mon, May 20, 2024 at 1:25 PM Bryan Bende <bbe...@gmail.com> > > wrote: > > > > > > > > > > > > > Thanks Pierre. I agree it would be good to kick out a release. I > > > > would > > > > > > > lean towards 1.6.0 since the commits seem to be improvements > > rather > > > > > > > than bug fixes for a patch. > > > > > > > > > > > > > > On Mon, May 20, 2024 at 1:08 PM Pierre Villard > > > > > > > <pierre.villard...@gmail.com> wrote: > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > We just merged a couple of improvements for the NiFi NAR Maven > > > > Plugin > > > > > > and > > > > > > > > another improvement has been merged some time ago for which the > > > > > > community > > > > > > > > expressed interest [1]. I think it could be a good time to > > release > > > > a > > > > > > new > > > > > > > > version, either as 1.5.2 or as 1.6.0. Once we have a new > > release, > > > > there > > > > > > > > will be a need for updating the NiFi code base and I have a PR > > > > ready > > > > > > for > > > > > > > > that [2]. > > > > > > > > > > > > > > > > I'm happy to help with the release process. > > > > > > > > > > > > > > > > Do you agree it is time for a new release or do you see > > additional > > > > > > > changes > > > > > > > > we should make? > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Pierre > > > > > > > > > > > > > > > > [1] https://github.com/apache/nifi-maven/pull/35 > > > > > > > > [2] https://issues.apache.org/jira/browse/NIFI-13267 > > > > > > > > > > > > > > > > > > >
