Changing the package of the Mojo would be a nice thing to do but is not required nor is it a stability issue.
Just to summarize; you've prepared two releases. One depends on the other. You've invited voters to look at them at the same time by using the first as the prereq to the second. I don't see a problem with this. On Tue, Jan 20, 2015 at 7:29 AM, Matt Gilman <[email protected]> wrote: > Also noticed the NarMojo class in the nar-maven-plugin is within a 'nifi' > package. Not within 'org.apache.nifi' like the rest of the codebase. Is > this a requirement for release or simply good practice? > > On Mon, Jan 19, 2015 at 10:51 PM, Joe Witt <[email protected]> wrote: > >> I do not have a strong view either way but agree with your statements of >> its stability. We will have to change all this later if we manage to go TLP >> so we're in for a bump regardless. >> >> So the key thing then is 'does this build seem legit, valid licenses, valid >> signatures, etc.' >> >> Thanks >> Joe >> >> On Mon, Jan 19, 2015 at 10:46 PM, Adam Taft <[email protected]> wrote: >> >> > Joe / all, >> > >> > In terms of semantic versioning, is there any reason why the nar-plugin >> > wouldn't just be released as 1.0.0? It should be stable and, as you >> state, >> > very rare to change. If any changes are made to it, they would likely be >> > bug fixes or new features. But isn't it feature stable for now? >> > >> > This doesn't preclude us from doing release candidates. We can obviously >> > still do nar-maven-plugin-1.0.0-RC1, if needed. >> > >> > Thanks, >> > >> > Adam >> > >> > >> > On Mon, Jan 19, 2015 at 10:26 PM, Joe Witt <[email protected]> wrote: >> > >> > > Team, >> > > >> > > I believe we have a way to proceed with a single vote process which >> > covers >> > > both the nar plugin and nifi build at the same time. Mentors please >> > chime >> > > in here if this is a bad idea but i very much hope it is ok as doing >> two >> > > separate votes seems *really* odd. Below is the proposed text. I am >> > > thinking we should offer more than the 72 hours since this is new and >> > huge >> > > and has two components. >> > > >> > > Mentors: We're definitely in need of guidance/recommendations here. >> > > >> > > I am also a bit hesitant to call a vote at this time even within the >> PPMC >> > > because it appears to be so new to people that familiarity just to >> > validate >> > > the release is low. We will no doubt need mentor involvement for >> binding >> > > votes (both here and in the IPMC for that matter). >> > > >> > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> > > To: [email protected] >> > > Subject: [VOTE] Release of Apache NiFi 0.0.1-incubating (RC1) >> > > >> > > >> > > >> > > Hello >> > > >> > > We are pleased to be calling this vote for the source release of Apache >> > > NiFi 0.0.1-incubating. >> > > >> > > Since this is our first release it will be slightly unique because we >> > need >> > > to release two components. >> > > >> > > The first component is the 'nar-maven-plugin' which allows us to build >> > > 'NiFi Archives' which is part of our classloader isolation model. The >> > > second is simply 'nifi' which is the full build and application that is >> > > 'Apache NiFi (incubating)'. >> > > >> > > After this first release we expect to be releasing the >> 'nar-maven-plugin' >> > > very rarely. >> > > >> > > So we'll break the information sections of this vote into two parts >> where >> > > one is for 'nar-maven-plugin' and the other 'nifi'. >> > > >> > > For the 'nar-maven-plugin' >> > > -------------------------- >> > > The source zip, including signatures, digests, etc. can be found at: >> > > https://repository.apache.org/content/repositories/orgapachenifi-1011 >> > > >> > > The specific repository path in that staging repo is: >> > > org/apache/nifi/nar-maven-plugin/0.0.1-incubating >> > > >> > > The sources.zip is called >> > > 'nar-maven-plugin-0.0.1-incubating-source-release.zip' >> > > >> > > The Git tag is nar-maven-plugin-0.0.1-incubating-RC1 >> > > >> > > The Git commit ID is 72abf18c2e045e9ef404050e2bffc9cef67d2558 >> > > >> > > >> > > >> > >> https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;a=commit;h=72abf18c2e045e9ef404050e2bffc9cef67d2558 >> > > >> > > Checksums of nar-maven-plugin-0.0.1-incubating-source-release.zip: >> > > MD5: 5a580756a17b0573efa3070c70585698 >> > > SHA1: a79ff8fd0d2f81523b675e4c69a7656160ff1214 >> > > >> > > 8 issues were closed/resolved for this release: >> > > >> > > >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12329307 >> > > >> > > ++++ >> > > Note once you have completed the verification of the 'nar-maven-plugin' >> > you >> > > will have 'nar-maven-plugin:0.0.1-incubating' in your local repo and >> thus >> > > you can move on to the 'nifi' build below which depends on it. >> > > ++++ >> > > >> > > For 'nifi' >> > > ------------- >> > > The source zip, including signatures, digests, etc. can be found at: >> > > https://repository.apache.org/content/repositories/orgapachenifi-1012 >> > > >> > > The specific repository path in that staging repo is: >> > > org/apache/nifi/nifi-parent/0.0.1-incubating >> > > >> > > The sources.zip is called >> > 'nifi-parent-0.0.1-incubating-source-release.zip' >> > > >> > > The Git tag is 'nifi-0.0.1-incubating-RC1' >> > > >> > > The Git commit ID is 8a6fe7124ed02e7e8dffa2bc179cd1afa5a5e319 >> > > >> > > >> https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;a=commit;h= >> > > < >> > > >> > >> https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;a=commit;h=72abf18c2e045e9ef404050e2bffc9cef67d2558 >> > > > >> > > 8a6fe7124ed02e7e8dffa2bc179cd1afa5a5e319 >> > > >> > > Checksums of nifi-parent-0.0.1-incubating-source-release.zip: >> > > MD5: e134bd2c2c24099af68b53ff1dccd938 >> > > SHA1: eeec54af99d3151a8cace4be836af11f65bb426b >> > > >> > > 113 issues were closed/resolved for this release: >> > > >> > > >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12329078 >> > > >> > > The following information applies to both the 'nar-maven-plugin' and >> > > 'nifi': >> > > >> > > Release artifacts are signed with the following key: >> > > https://people.apache.org/keys/committer/joewitt.asc >> > > >> > > KEYS file available here: >> > > https://dist.apache.org/repos/dist/release/incubator/nifi/KEYS >> > > >> > > The vote will be open for 96 hours. >> > > Please download the release candidate and evaluate the necessary items >> > > including checking hashes, signatures, build from source, and test. >> The >> > > please vote: >> > > >> > > [ ] +1 Release this package as Apache NiFi 0.0.1-incubating >> > > [ ] +0 no opinion >> > > [ ] -1 Do not release this package because because... >> > > >> > > >> > > >> > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> > > >> > >>
