Github user joewitt commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/53#issuecomment-100330127
  
    Tim
    
    1) You did a great job.  That you did it at all is highly appreciated.
    2) This is fine.  Because it is a test dependency and we're not pulling in 
source nor would it be part of a convenience binary we'd put out the burden is 
extremely small.  It is also apache licensed so woohoo.  Now it could pull in 
deps that aren't legit.  I didn't check.  But it doesn't matter given my 
previous statements (for this case).
    3) I am not a mongo expert at all.  Perhaps this is worth tossing out as a 
question to the dev mailing list and see if anyone has an opinion on it you can 
discuss with.
    
    We will do a more thorough review as well and send feedback.
    
    But clearly a quality effort so thank you very much.
    Joe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to