Github user tequalsme commented on the pull request:
https://github.com/apache/incubator-nifi/pull/53#issuecomment-100329244
Good eye, Joe. I was about to comment on a couple of things for this pull
request:
1 - I wasn't sure what exactly the verbiage should be in the NOTICE. I
guessed based on their website, and it looks like I guessed wrong. I'll get it
from their LICENSE and update.
2 - I am using embedmongo-maven-plugin for my unit tests. I want to make
sure it's ok to introduce this new dependency, could someone validate?
https://github.com/joelittlejohn/embedmongo-maven-plugin
3 - The 3.0 Java driver series was released a month ago and has a brand new
API (that I have not used). The 2.x API is still supported but marked
deprecated. I though it best to go with 2.x than to introduce a slew of
deprecation warnings. But, since these processors are so simple, maybe it would
be best for me to use the new API.
Thanks for reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
