oh definitely, I'd need a contrib guide from Nifi to customize the final pre-commit check. If there wasn't one when I wired things up I'd submit a guide that documents whatever I'm able to reverse engineer out of the build and recent patch feedback. :)
On Thu, May 21, 2015 at 1:59 PM, Dan Bress <[email protected]> wrote: > I think this is a cool effort, but can we also put some effort into a > committer guide to outline what this change, and NIFI-271/-Pcontrib-check > are looking for? I'd like to be able to write code that adheres to the > guidance from the get-go, rather than reworking it in later. I thought > there was a ticket to author a committer guide, but I just did a search and > didn't find one. NIFI-357 was the closest thing I found. > > Dan Bress > Software Engineer > ONYX Consulting Services > > ________________________________________ > From: Sean Busbey <[email protected]> > Sent: Thursday, May 21, 2015 12:32 PM > To: [email protected] > Subject: Re: Pre-commit patch testing > > So far as I know this particular issue is well in hand. The big help would > be whatever other issues our use turns up. :) > > On Thu, May 21, 2015 at 11:16 AM, Joe Witt <[email protected]> wrote: > > > Sean > > > > Sorry meant to reply two days ago. My own preference is to wait until > the > > kinks are ironed out unless current use of the workaround helps with the > > ironing out of those kinks. > > > > Do you need that help or have it in hand? > > > > Thanks > > Joe > > On May 21, 2015 11:50 AM, "Sean Busbey" <[email protected]> wrote: > > > > > bump? > > > > > > On Mon, May 18, 2015 at 4:49 PM, Sean Busbey <[email protected]> > > wrote: > > > > > > > Heya folks! > > > > > > > > Last week I worked through using the Hadoop Precommit Patch Tester to > > > > evaluate NiFi patches[1]. > > > > > > > > Most of the edges have been sanded down. There is still one > outstanding > > > > major change that's needed to deal with NiFi's multi-project repo > > layout > > > > [2]. That fix is more involved, because it's providing a major boost > in > > > the > > > > flexibility of the precommit framework (yay!) so I'm not sure when > it's > > > > going to land. > > > > > > > > I have a work around for that particular issue for the specifics of > > > NiFi's > > > > layout[3]. However, it is definitely not what will be in the version > > that > > > > is committed and the way NiFi hooks into the test framework will be > > > > different once things settle. > > > > > > > > Would folks prefer to wait for the fix before using the precommit > > tester > > > > or run on top of my workaround for now (changing once the fix lands)? > > > > > > > > > > > > [1]: https://issues.apache.org/jira/browse/NIFI-577 > > > > > > > > [2]: https://issues.apache.org/jira/browse/HADOOP-11929 > > > > > > > > [3]: https://github.com/busbey/hadoop/commits/NIFI-577 > > > > > > > > > > > > -- > > > > Sean > > > > > > > > > > > > > > > > -- > > > Sean > > > > > > > > > -- > Sean > -- Sean
