[ 
https://issues.apache.org/jira/browse/NUTCH-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118394#comment-18118394
 ] 

ASF GitHub Bot commented on NUTCH-3214:
---------------------------------------

sonarqubecloud[bot] commented on PR #970:
URL: https://github.com/apache/nutch/pull/970#issuecomment-5797186109

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_nutch&pullRequest=970) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_nutch&pullRequest=970&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_nutch&pullRequest=970&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_nutch&pullRequest=970&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [51.8% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_nutch&pullRequest=970&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1.5% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_nutch&pullRequest=970&metric=new_duplicated_lines_density&view=list)
  
     
   <!

> Remove Javadoc author tags so Apache Yetus author check passes
> --------------------------------------------------------------
>
>                 Key: NUTCH-3214
>                 URL: https://issues.apache.org/jira/browse/NUTCH-3214
>             Project: Nutch
>          Issue Type: Improvement
>          Components: ci/cd
>    Affects Versions: 1.23
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Trivial
>             Fix For: 1.24
>
>
> Apache Yetus test-patch is voting -1 on the @author plugin because Nutch 
> still has Javadoc @author tags in Java sources.
> The GitHub workflow (.github/workflows/yetus.yml) runs 
> apache/[email protected] with plugins: all (minus jira, gitlab, 
> unit, compile). The author plugin fails when it finds @author in the patch 
> or, on master, in the tree. Typical vote text:
>   _*-1 @author  The patch appears to contain N @author tags which the 
> community has agreed to not allow in code contributions.*_
> This matches long-standing ASF practice: author tags are discouraged because 
> they confuse ownership (ASF copyright, not per-file authors) and committer 
> protection. Authorship belongs in git history and release notes, not in 
> source files. Same cleanup as Hadoop (HADOOP-1147 / HADOOP-6031) and other 
> ASF projects.
> Proposed change
> - Strip @author (and only those) Javadoc lines from Nutch-owned Java sources.
> - Do not rewrite surrounding comments beyond dropping the tags.
> - Do not add Yetus author-ignore-list entries for these files; the tags 
> should go away rather than be excepted.
> - No runtime or API change.
> Authors remain visible via git log / git blame. Do not add names to 
> CHANGES.md as part of this cleanup.
> Acceptance
> - No @author tags remain in Nutch Java sources.
> - Apache Yetus author check votes +1 on a follow-up PR and on master.
> This is mechanical Javadoc cleanup so Yetus CI can go green; it is not a 
> functional bug.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to